Details

Reviewers

michal
kamil
ginsu
tomek
ashoat

Commits

rCOMM55cbecae5c70: [lib] Call logout when connectionIssue is set

Summary

issue: https://linear.app/comm/issue/ENG-5914/stop-calling-logout-from-socket
See this comment. We want to stop calling logout from the Socket, and instead set conneciotnIssue. But for the time baing we will log the user out from KeyserverConnectionHandler if connectionIssue was set. This will be updated in the future to instead retry the keyserver from time to time.

Test Plan

Dispatched the setConnectionIssueActionTypes, checked that the user is logged out.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Dec 14 2023, 4:21 AM

Herald added a subscriber: ashoat. · View Herald TranscriptDec 14 2023, 4:21 AM

inka added parent revisions: D10288: [lib] Add setConnectionIssueActionType, D10292: [lib][web][native] Simplify logout call.Dec 14 2023, 4:25 AM

inka mentioned this in D10332: [lib][web][native] Stop logging out from the Socket.Dec 14 2023, 4:31 AM

inka added a child revision: D10332: [lib][web][native] Stop logging out from the Socket.Dec 14 2023, 4:31 AM

Harbormaster completed remote builds in B25060: Diff 34625.Dec 14 2023, 4:39 AM

inka requested review of this revision.Dec 14 2023, 4:39 AM

ginsu accepted this revision.Dec 14 2023, 9:40 AM

This revision is now accepted and ready to land.Dec 14 2023, 9:40 AM

Glad I caught this – @inka and @ginsu, please be more careful next time

lib/components/keyserver-connection-handler.js
28 ↗	(On Diff #34625)	We should not be calling this inline during a component render. Is this supposed to be in an effect?

This revision now requires changes to proceed.Dec 15 2023, 10:09 AM

Wrap in useEffect

Harbormaster completed remote builds in B25207: Diff 34825.Dec 19 2023, 2:52 AM

tomek accepted this revision.Dec 19 2023, 6:35 AM

tomek added inline comments.

lib/components/keyserver-connection-handler.js
23–31 ↗	(On Diff #34825)	It might be possible that one connection issue is overridden by another - in that case, we would dispatch a logout twice. To avoid that, we should select a boolean telling if there's a connection issue.