Page MenuHomePhabricator
Differential D10497

[web] introduce community header button
ClosedPublic
Actions

Authored by ginsu on Dec 29 2023, 11:59 AM.
Tags
None
Referenced Files
F3400573: D10497.id35111.diff
Mon, Dec 2, 7:50 AM
F3400014: D10497.diff
Mon, Dec 2, 5:52 AM
Unknown Object (File)
Sun, Nov 24, 10:44 AM
Unknown Object (File)
Oct 27 2024, 8:20 AM
Unknown Object (File)
Oct 27 2024, 8:17 AM
Unknown Object (File)
Oct 9 2024, 8:21 AM
Unknown Object (File)
Oct 2 2024, 12:21 PM
Unknown Object (File)
Sep 30 2024, 1:00 AM
View All 62 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
rohan
Commits
rCOMM1b5844aa048c: [web] introduce community header button
Summary

This diff introduces the community header button. This will be used by the two community buttons we will have in the header.

For context here is what the community header should look like:

Screenshot 2023-12-29 at 3.08.06 PM.png (404×1 px, 79 KB)

Linear task: https://linear.app/comm/issue/ENG-5933/top-bar

Depends on D10496

Test Plan

Please see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Dec 29 2023, 11:59 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 29 2023, 11:59 AM
ginsu edited the summary of this revision. (Show Details)Dec 29 2023, 12:12 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, kamil, rohan.
ginsu added a parent revision: D10496: [web] update colors in app directory modal to use enum option color family.
ginsu attached a referenced file: F1013632: Screenshot 2023-12-29 at 3.08.06 PM.png. (Show Details)
Harbormaster completed remote builds in B25408: Diff 35107.Dec 29 2023, 12:22 PM
ginsu requested review of this revision.Dec 29 2023, 12:22 PM
ginsu added a child revision: D10498: [web] introduce community header actions.Dec 29 2023, 12:41 PM
rohan accepted this revision.Dec 29 2023, 2:07 PM
This revision is now accepted and ready to land.Dec 29 2023, 2:07 PM
rohan added a comment.Dec 29 2023, 2:08 PM

Just a question - do you plan to add the Roles community action here later as well?

ginsu added a comment.Dec 29 2023, 2:28 PM

Just a question - do you plan to add the Roles community action here later as well?

Screenshot 2023-12-29 at 5.27.21 PM.png (1×1 px, 92 KB)

The roles + manage invite link community actions will live in this new community settings

ginsu attached a referenced file: F1013762: Screenshot 2023-12-29 at 5.27.21 PM.png. (Show Details)Dec 29 2023, 2:28 PM
rohan added a comment.Dec 29 2023, 2:31 PM
In D10497#303263, @ginsu wrote:

Just a question - do you plan to add the Roles community action here later as well?

Screenshot 2023-12-29 at 5.27.21 PM.png (1×1 px, 92 KB)

The roles + manage invite link community actions will live in this new community settings

Ah ok got it, thanks!

ginsu updated this revision to Diff 35111.Dec 29 2023, 2:40 PM

rebase before landing

This revision was landed with ongoing or failed builds.Dec 29 2023, 2:42 PM
Closed by commit rCOMM1b5844aa048c: [web] introduce community header button (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM1b5844aa048c: [web] introduce community header button.
Harbormaster completed remote builds in B25412: Diff 35111.Dec 29 2023, 3:11 PM

Revision Contents
Changeset List

PathSize
web/
community-header/
16 lines
40 lines
9 lines

Diff 35107

View Options

web/community-header/community-header-button.css

Loading...
View Options

web/community-header/community-header-button.react.js

Loading...
View Options

web/theme.css

Loading...