Differential D10348

[web] fixup pinned message modal
ClosedPublic
Actions

Authored by ginsu on Dec 15 2023, 12:32 AM.

Tags

None

Referenced Files

	F3506990: D10348.diff
	Fri, Dec 20, 6:55 PM

	Unknown Object (File)
	Nov 18 2024, 4:05 PM

	Unknown Object (File)
	Nov 18 2024, 2:35 AM

	Unknown Object (File)
	Nov 18 2024, 1:28 AM

	Unknown Object (File)
	Nov 18 2024, 12:22 AM

	Unknown Object (File)
	Oct 31 2024, 8:47 AM

	Unknown Object (File)
	Oct 3 2024, 4:52 PM

	Unknown Object (File)
	Oct 3 2024, 4:52 PM

View All 62 Files

Subscribers

Details

Reviewers

atul
rohan
kamil

Commits

rCOMM38684f16525b: [web] fixup pinned message modal

Summary

As I was cleaning up the pinned message modal, I noticed several things not working properly with this modal.

If you unpinned a message from within the modal, the title of the modal would not update to reflect the correct number of pinned messages in the chat
If there were no pinned messages in the modal, there was no text/output to indicate to the user that the list was empty

Linear task: https://linear.app/comm/issue/ENG-5945/fix-up-pinned-messages-modal

Depends on D10347

Test Plan

Please see the demo video below

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Dec 15 2023, 12:32 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 15 2023, 12:32 AM

ginsu edited the summary of this revision. (Show Details)Dec 15 2023, 12:42 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, rohan, kamil.

ginsu added a parent revision: D10347: [lib/native/web] introduce pinnedMessageCountText function.

ginsu attached a referenced file: F951290: Screen Recording 2023-12-15 at 3.41.45 AM.mov. (Show Details)

ginsu attached a referenced file: F951284: Screen Recording 2023-12-13 at 2.36.25 PM.mov. (Show Details)

Harbormaster completed remote builds in B25105: Diff 34692.Dec 15 2023, 1:34 AM

ginsu requested review of this revision.Dec 15 2023, 1:34 AM

Thanks for fixing this!

This revision is now accepted and ready to land.Dec 15 2023, 8:14 AM

rebase before landing

Harbormaster completed remote builds in B25518: Diff 35250.Jan 4 2024, 7:12 PM

rebase

Harbormaster completed remote builds in B25521: Diff 35253.Jan 4 2024, 7:44 PM

Closed by commit rCOMM38684f16525b: [web] fixup pinned message modal (authored by ginsu). · Explain WhyJan 4 2024, 8:03 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM38684f16525b: [web] fixup pinned message modal.

Revision Contents
Changeset List

Path

Size

web/

chat/

thread-top-bar.react.js

9 lines

modals/

chat/

pinned-messages-modal.css

7 lines

pinned-messages-modal.react.js

14 lines

Diff 35258

web/chat/thread-top-bar.react.js

Loading...

web/modals/chat/pinned-messages-modal.css

Loading...

web/modals/chat/pinned-messages-modal.react.js

Loading...