Page MenuHomePhabricator
Differential D10611

[web] introduce user settings list item
ClosedPublic
Actions

Authored by ginsu on Jan 11 2024, 9:41 AM.
Tags
None
Referenced Files
F3406751: D10611.id35554.diff
Wed, Dec 4, 3:23 AM
F3406692: D10611.id35805.diff
Wed, Dec 4, 3:05 AM
F3406642: D10611.id35790.diff
Wed, Dec 4, 2:39 AM
F3404865: D10611.diff
Tue, Dec 3, 1:34 PM
Unknown Object (File)
Wed, Nov 13, 6:14 AM
Unknown Object (File)
Wed, Nov 13, 6:14 AM
Unknown Object (File)
Wed, Nov 13, 6:14 AM
Unknown Object (File)
Wed, Nov 13, 6:14 AM
View All 72 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMM20a5f76447d9: [web] introduce user settings list item
Summary

This diff introduces the settings list item. This component will be used in the settings list to swtich between the different user settings which I will introduce in a subsequent diff.

For context here is what the user settings list looks like in the figma:

Screenshot 2024-01-11 at 12.44.10 PM.png (890×636 px, 42 KB)

Linear task: https://linear.app/comm/issue/ENG-5952/settings-list-ui

Depends on D10610

Test Plan

Please see the demo video below:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Jan 11 2024, 9:41 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 11 2024, 9:41 AM
ginsu edited the summary of this revision. (Show Details)Jan 11 2024, 9:45 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu attached a referenced file: F1056021: Screenshot 2024-01-11 at 12.44.10 PM.png. (Show Details)
ginsu added a child revision: D10612: [web] introduce user settings list.Jan 11 2024, 9:55 AM
Harbormaster completed remote builds in B25713: Diff 35554.Jan 11 2024, 10:08 AM
ginsu requested review of this revision.Jan 11 2024, 10:08 AM
ginsu edited the summary of this revision. (Show Details)Jan 11 2024, 4:25 PM
ginsu added a parent revision: D10610: [web] introduce panel header component.
atul accepted this revision.Jan 12 2024, 12:43 PM
atul added inline comments.
web/settings/user-settings-list-item.react.js
26–30 ↗(On Diff #35554)

Could be memoized, but prob negligible impact.

This revision is now accepted and ready to land.Jan 12 2024, 12:43 PM
ginsu updated this revision to Diff 35790.Jan 18 2024, 9:00 AM

address comments

Harbormaster completed remote builds in B25895: Diff 35790.Jan 18 2024, 9:19 AM
Closed by commit rCOMM20a5f76447d9: [web] introduce user settings list item (authored by ginsu). · Explain WhyJan 18 2024, 9:27 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM20a5f76447d9: [web] introduce user settings list item.

Revision Contents
Changeset List

Diff 35805

View Options

web/settings/user-settings-list-item.css

Loading...
View Options

web/settings/user-settings-list-item.react.js

Loading...