Details

Reviewers

marcin
bartek
kamil

Commits

rCOMMa1a155927cad: [native] Create and upload backup compaction

Summary

Update the JS and Rust code to upload sqlite backup compaction. First Rust saves the encrypted user keys data to a file and schedules a C++ code the to also save the database compaction. After both of these are done it uploads them to the backup service. If all operations succeed the JS promise is resolved otherwise it's rejected.

Depends on D10858

Test Plan

Click the test button in JS, make sure the backup is uploaded to the backup service and files are removed. [with later diffs] tested that the backup can be restored. Tested that errors are propageated to the JS promise.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

michal created this revision.Jan 29 2024, 2:42 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 29 2024, 2:42 AM

Harbormaster completed remote builds in B26241: Diff 36243.Jan 29 2024, 3:02 AM

michal requested review of this revision.Jan 29 2024, 3:02 AM

marcin accepted this revision.Jan 30 2024, 9:13 AM

This revision is now accepted and ready to land.Jan 30 2024, 9:13 AM

Simplified the codeflow a bit after changes to the previous diff.

michal added a child revision: D10987: [native] Download and restore compaction.Feb 7 2024, 9:48 AM

Harbormaster completed remote builds in B26621: Diff 36787.Feb 7 2024, 9:52 AM

kamil accepted this revision.Feb 12 2024, 8:16 AM

kamil added inline comments.

native/native_rust_library/src/backup.rs
47 ↗	(On Diff #36787)	hmm... this looks confusing to not have `reject()` method, but I assume there was a good reason to do it that way
47 ↗	(On Diff #36787)	actually I think I should ask about it in D10858
native/native_rust_library/src/constants.rs
3 ↗	(On Diff #36787)	do we need it?
native/profile/backup-menu.react.js
37 ↗	(On Diff #36787)	Match capitalization

Fix naming

native/native_rust_library/src/backup.rs
47 ↗	(On Diff #36787)	I did it this way, because it simplifies the code in the future `compaction_upload_promises` and removed some code duplication. While it's not the way it works in JS I don't think it's that confusing and it doesn't introduce any footguns.
native/native_rust_library/src/constants.rs
3 ↗	(On Diff #36787)	We stopped using `KEY_SIZE` in this diff.

Harbormaster completed remote builds in B26967: Diff 37326.Feb 19 2024, 8:11 AM

ashoat added inline comments.Feb 19 2024, 3:57 PM

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
26 ↗	(On Diff #37326)	Nit – is there intentionally an extra slash at the start of this line?

Fix comment

Harbormaster completed remote builds in B27098: Diff 37494.Feb 23 2024, 3:48 AM

Closed by commit rCOMMa1a155927cad: [native] Create and upload backup compaction (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyFeb 23 2024, 8:45 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMMa1a155927cad: [native] Create and upload backup compaction.

[native] Create and upload backup compaction
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 36243

native/backup/use-client-backup.js

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

native/cpp/CommonCpp/_generated/commJSI.h

native/native_rust_library/RustBackupExecutor.h

native/native_rust_library/RustBackupExecutor.cpp

native/native_rust_library/src/backup.rs

native/native_rust_library/src/constants.rs

native/native_rust_library/src/lib.rs

native/profile/backup-menu.react.js

native/schema/CommCoreModuleSchema.js

[native] Create and upload backup compactionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 36243

native/backup/use-client-backup.js

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

native/cpp/CommonCpp/_generated/commJSI.h

native/native_rust_library/RustBackupExecutor.h

native/native_rust_library/RustBackupExecutor.cpp

native/native_rust_library/src/backup.rs

native/native_rust_library/src/constants.rs

native/native_rust_library/src/lib.rs

native/profile/backup-menu.react.js

native/schema/CommCoreModuleSchema.js

[native] Create and upload backup compaction
ClosedPublic
Actions

Revision Contents
Changeset List