Page MenuHomePhabricator
Differential D10864

[native] Expose UpdateDeviceList RPC to JS
ClosedPublic
Actions

Authored by bartek on Jan 29 2024, 5:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 15, 7:04 AM
Unknown Object (File)
Tue, Nov 12, 5:16 AM
Unknown Object (File)
Thu, Nov 7, 2:01 AM
Unknown Object (File)
Fri, Nov 1, 11:37 PM
Unknown Object (File)
Fri, Nov 1, 11:33 PM
Unknown Object (File)
Fri, Nov 1, 11:33 PM
Unknown Object (File)
Fri, Nov 1, 11:33 PM
Unknown Object (File)
Fri, Nov 1, 11:33 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
varun
kamil
Commits
rCOMM82adcac2f329: [native] Expose UpdateDeviceList RPC to JS
Summary

Exposed UpdateDeviceList RPC to JS via JSI.

Depends on D10863.

Test Plan

Called the method from JS, console.logged the result.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Jan 29 2024, 5:27 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 29 2024, 5:27 AM
bartek added a child revision: D10865: [native] Expose LogInSecondaryDevice RPC to JS.Jan 29 2024, 5:28 AM
Harbormaster failed remote builds in B26249: Diff 36260!Jan 29 2024, 5:48 AM
bartek updated this revision to Diff 36269.Jan 29 2024, 7:14 AM

Fix broken rebase

Harbormaster completed remote builds in B26258: Diff 36269.Jan 29 2024, 7:33 AM
bartek published this revision for review.Jan 29 2024, 7:48 AM
kamil accepted this revision.Jan 31 2024, 2:52 AM
This revision is now accepted and ready to land.Jan 31 2024, 2:52 AM
bartek updated this revision to Diff 36609.Feb 5 2024, 3:45 AM

Rebase

Harbormaster failed remote builds in B26485: Diff 36609!Feb 5 2024, 4:10 AM
bartek updated this revision to Diff 36612.Feb 5 2024, 4:59 AM

Rebase on fix

Harbormaster failed remote builds in B26488: Diff 36612!Feb 5 2024, 5:13 AM
bartek updated this revision to Diff 36614.Feb 5 2024, 5:19 AM

Rebase on fix

Harbormaster completed remote builds in B26490: Diff 36614.Feb 5 2024, 5:38 AM
bartek updated this revision to Diff 36971.Feb 12 2024, 1:00 AM

Rebase before landing

Harbormaster completed remote builds in B26739: Diff 36971.Feb 12 2024, 1:16 AM
Closed by commit rCOMM82adcac2f329: [native] Expose UpdateDeviceList RPC to JS (authored by bartek). · Explain WhyFeb 12 2024, 1:26 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM82adcac2f329: [native] Expose UpdateDeviceList RPC to JS.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
6 lines
32 lines
_generated/
native_rust_library/
src/
52 lines
schema/
6 lines

Diff 36609

View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/rustJSI.h

Loading...
View Options

native/native_rust_library/src/lib.rs

Loading...
View Options

native/schema/CommRustModuleSchema.js

Loading...