Differential D11101

[services] tidy up our identity service code
ClosedPublic
Actions

Authored by varun on Feb 15 2024, 9:37 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Mar 30, 2:56 PM

	Unknown Object (File)
	Thu, Mar 27, 6:32 PM

	Unknown Object (File)
	Sun, Mar 23, 3:41 AM

	Unknown Object (File)
	Thu, Mar 20, 8:17 AM

	Unknown Object (File)
	Fri, Mar 14, 4:58 AM

	Unknown Object (File)
	Mar 3 2025, 12:52 PM

	Unknown Object (File)
	Feb 26 2025, 7:17 AM

	Unknown Object (File)
	Feb 26 2025, 7:10 AM

View All 67 Files

Subscribers

Details

Reviewers

bartek
will
michal

Commits

rCOMM821dd280067d: [services] tidy up our identity service code

Summary

fix all the cargo clippy issues

Test Plan

cargo build

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Feb 15 2024, 9:37 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 15 2024, 9:38 PM

Harbormaster completed remote builds in B26950: Diff 37293.Feb 15 2024, 9:53 PM

varun requested review of this revision.Feb 15 2024, 9:53 PM

Looks good to me. Thanks for cleaning this up

This revision is now accepted and ready to land.Feb 15 2024, 10:01 PM

bartek accepted this revision.Feb 15 2024, 10:31 PM

Closed by commit rCOMM821dd280067d: [services] tidy up our identity service code (authored by varun). · Explain WhyFeb 22 2024, 8:18 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM821dd280067d: [services] tidy up our identity service code.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

2 lines

database/

1 line

16 lines

websockets/

4 lines

6 lines

shared/

tunnelbroker_messages/

src/

1 line

Diff 37473

services/identity/src/config.rs

	Show First 20 Lines • Show All 85 Lines • ▼ Show 20 Lines		public:
	std::string getMetadata(std::string entry_name) const override;			std::string getMetadata(std::string entry_name) const override;

	#ifdef EMSCRIPTEN			#ifdef EMSCRIPTEN
	std::vector<WebThread> getAllThreadsWeb() const override;			std::vector<WebThread> getAllThreadsWeb() const override;
	void replaceThreadWeb(const WebThread &thread) const override;			void replaceThreadWeb(const WebThread &thread) const override;
	#else			#else
	static void clearSensitiveData();			static void clearSensitiveData();
	static void initialize(std::string &databasePath);			static void initialize(std::string &databasePath);
				void createMainCompaction(std::string backupID) const override;
	#endif			#endif
	};			};

	} // namespace comm			} // namespace comm

services/identity/src/database/device_list.rs

	Show First 20 Lines • Show All 85 Lines • ▼ Show 20 Lines		public:
	std::string getMetadata(std::string entry_name) const override;			std::string getMetadata(std::string entry_name) const override;

	#ifdef EMSCRIPTEN			#ifdef EMSCRIPTEN
	std::vector<WebThread> getAllThreadsWeb() const override;			std::vector<WebThread> getAllThreadsWeb() const override;
	void replaceThreadWeb(const WebThread &thread) const override;			void replaceThreadWeb(const WebThread &thread) const override;
	#else			#else
	static void clearSensitiveData();			static void clearSensitiveData();
	static void initialize(std::string &databasePath);			static void initialize(std::string &databasePath);
				void createMainCompaction(std::string backupID) const override;
	#endif			#endif
	};			};

	} // namespace comm			} // namespace comm

services/identity/src/token.rs

	Show First 20 Lines • Show All 85 Lines • ▼ Show 20 Lines		public:
	std::string getMetadata(std::string entry_name) const override;			std::string getMetadata(std::string entry_name) const override;

	#ifdef EMSCRIPTEN			#ifdef EMSCRIPTEN
	std::vector<WebThread> getAllThreadsWeb() const override;			std::vector<WebThread> getAllThreadsWeb() const override;
	void replaceThreadWeb(const WebThread &thread) const override;			void replaceThreadWeb(const WebThread &thread) const override;
	#else			#else
	static void clearSensitiveData();			static void clearSensitiveData();
	static void initialize(std::string &databasePath);			static void initialize(std::string &databasePath);
				void createMainCompaction(std::string backupID) const override;
	#endif			#endif
	};			};

	} // namespace comm			} // namespace comm

services/identity/src/websockets/errors.rs

	Show First 20 Lines • Show All 85 Lines • ▼ Show 20 Lines		public:
	std::string getMetadata(std::string entry_name) const override;			std::string getMetadata(std::string entry_name) const override;

	#ifdef EMSCRIPTEN			#ifdef EMSCRIPTEN
	std::vector<WebThread> getAllThreadsWeb() const override;			std::vector<WebThread> getAllThreadsWeb() const override;
	void replaceThreadWeb(const WebThread &thread) const override;			void replaceThreadWeb(const WebThread &thread) const override;
	#else			#else
	static void clearSensitiveData();			static void clearSensitiveData();
	static void initialize(std::string &databasePath);			static void initialize(std::string &databasePath);
				void createMainCompaction(std::string backupID) const override;
	#endif			#endif
	};			};

	} // namespace comm			} // namespace comm

services/identity/src/websockets/mod.rs

Loading...

shared/tunnelbroker_messages/src/lib.rs

Loading...