Paths

Table of Contentst

Differential D10985

[backup client] Refactor ws creation
ClosedPublic
Actions

Authored by michal on Feb 7 2024, 9:38 AM.

Tags

None

Referenced Files

	F3491854: D10985.id36789.diff
	Wed, Dec 18, 8:51 PM

	F3491842: D10985.id37533.diff
	Wed, Dec 18, 8:46 PM

	F3490880: D10985.diff
	Wed, Dec 18, 5:42 PM

	Unknown Object (File)
	Mon, Dec 16, 5:50 PM

	Unknown Object (File)
	Wed, Dec 11, 5:03 PM

	Unknown Object (File)
	Wed, Nov 20, 2:54 PM

	Unknown Object (File)
	Wed, Nov 20, 2:54 PM

	Unknown Object (File)
	Oct 22 2024, 1:06 PM

View All 58 Files

Subscribers

Details

Reviewers

marcin
bartek
kamil

Commits

rCOMM1361796b7f3f: [backup client] Refactor ws creation

Summary

I found a nice way to simplify the websocket creation on the backup client, that will work even better with the future diffs. get_log_ws_response functions has been merged inside the new create_log_ws_connection function, that is used by both log upload and download.

Depends on D10984

Test Plan

Run the backup integration tests.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Feb 7 2024, 9:38 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 7 2024, 9:38 AM

michal added a child revision: D10986: [backup client] Downloading logs.Feb 7 2024, 9:44 AM

Harbormaster completed remote builds in B26623: Diff 36789.Feb 7 2024, 9:53 AM

michal requested review of this revision.Feb 7 2024, 9:53 AM

kamil accepted this revision.Feb 9 2024, 3:18 AM

This revision is now accepted and ready to land.Feb 9 2024, 3:18 AM

bartek accepted this revision.Feb 9 2024, 7:27 AM

Rebase

This revision was landed with ongoing or failed builds.Feb 23 2024, 9:01 AM

Closed by commit rCOMM1361796b7f3f: [backup client] Refactor ws creation (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain Why

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM1361796b7f3f: [backup client] Refactor ws creation.

Harbormaster failed remote builds in B27119: Diff 37533!Feb 23 2024, 9:04 AM

Harbormaster completed remote builds in B27119: Diff 37533.Feb 26 2024, 2:01 PM

Revision Contents
Changeset List

Path

Size

shared/

backup_client/

src/

103 lines

comm-lib/

src/

backup/

2 lines

Diff 37534

shared/backup_client/Cargo.lock

Loading...

shared/backup_client/src/lib.rs

Loading...

shared/comm-lib/src/backup/mod.rs

Loading...