Page MenuHomePhabricator

[backup] Move authentication inside of the websocket
ClosedPublic

Authored by michal on Feb 12 2024, 7:10 AM.
Tags
None
Referenced Files
F2165768: D11039.diff
Tue, Jul 2, 2:41 AM
Unknown Object (File)
Tue, Jun 25, 9:46 PM
Unknown Object (File)
Tue, Jun 25, 7:48 PM
Unknown Object (File)
Tue, Jun 25, 12:35 AM
Unknown Object (File)
Sat, Jun 22, 10:02 PM
Unknown Object (File)
Sat, Jun 22, 9:21 AM
Unknown Object (File)
Fri, Jun 21, 5:47 AM
Unknown Object (File)
Fri, Jun 14, 12:15 AM
Subscribers

Details

Summary

Unfortunately non-native web websockets (neither in JS nor in Rust compiled to WASM) allow us to attach additional headers to the first HTTP requests that starts the websocket. Because of that we need to migrate to another approach -> client must first send an authorization message.

Depends on D11038

Test Plan

Run backup integration tests.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil added 1 blocking reviewer(s): bartek.
This revision is now accepted and ready to land.Feb 13 2024, 5:14 AM