This separates client and server messages into two different enums for organization purposes. This will be reflected in the client javascript flow types for proper runtime checking.
Depends on D10981
Details
Details
Summary
Test Plan
cargo build
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 5 2024, 7:40 AM2024-02-05 07:40:22 (UTC-8)
will retitled this revision from [identity] [shared] Separate identity search messages into client and server messages to [identity] [shared] [1/n] Separate identity search messages into client and server messages.Feb 5 2024, 7:42 AM2024-02-05 07:42:22 (UTC-8)
Harbormaster completed remote builds in B26498: Diff 36628.Feb 5 2024, 8:00 AM2024-02-05 08:00:04 (UTC-8)
will edited the summary of this revision. (Show Details)Feb 6 2024, 11:34 PM2024-02-06 23:34:44 (UTC-8)
will added a parent revision: D10981: [shared] [identity] Move search result to response and add ids.
will retitled this revision from [identity] [shared] [1/n] Separate identity search messages into client and server messages to [identity] [shared] [3/n] Separate identity search messages into client and server messages.
Harbormaster completed remote builds in B26619: Diff 36780.Feb 7 2024, 7:35 AM2024-02-07 07:35:59 (UTC-8)
will retitled this revision from [identity] [shared] [3/n] Separate identity search messages into client and server messages to [identity] [shared] Separate identity search messages into client and server messages.Feb 8 2024, 10:13 AM2024-02-08 10:13:54 (UTC-8)
Harbormaster failed remote builds in B26659: Diff 36867!Feb 8 2024, 10:22 AM2024-02-08 10:22:42 (UTC-8)
Harbormaster completed remote builds in B26774: Diff 37014.Feb 13 2024, 12:49 AM2024-02-13 00:49:41 (UTC-8)
varun added inline comments.
This revision is now accepted and ready to land.Feb 13 2024, 11:21 AM2024-02-13 11:21:01 (UTC-8)
Harbormaster completed remote builds in B26936: Diff 37277.Feb 15 2024, 12:54 PM2024-02-15 12:54:27 (UTC-8)
Harbormaster completed remote builds in B27003: Diff 37364.Feb 20 2024, 7:22 AM2024-02-20 07:22:57 (UTC-8)
Harbormaster failed remote builds in B27184: Diff 37617!Feb 26 2024, 11:28 AM2024-02-26 11:28:27 (UTC-8)
This revision was landed with ongoing or failed builds.Feb 26 2024, 12:45 PM2024-02-26 12:45:11 (UTC-8)
Closed by commit rCOMMc79b20fa5646: [identity] [shared] Separate identity search messages into client and server… (authored by will). · Explain Why
This revision was automatically updated to reflect the committed changes.
Harbormaster completed remote builds in B27185: Diff 37618.Feb 26 2024, 12:48 PM2024-02-26 12:48:31 (UTC-8)
Harbormaster completed remote builds in B27184: Diff 37617.Feb 26 2024, 4:01 PM2024-02-26 16:01:12 (UTC-8)