Page MenuHomePhabricator

[lib] Replace sessionRecoveryInProgress with actionSessionRecovery
ClosedPublic

Authored by ashoat on Mar 3 2024, 8:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 29 2024, 7:17 AM
Unknown Object (File)
Oct 4 2024, 3:44 AM
Unknown Object (File)
Oct 4 2024, 3:44 AM
Unknown Object (File)
Oct 4 2024, 3:44 AM
Unknown Object (File)
Oct 4 2024, 3:44 AM
Unknown Object (File)
Oct 4 2024, 3:43 AM
Unknown Object (File)
Sep 1 2024, 7:16 AM
Unknown Object (File)
Aug 29 2024, 12:45 PM
Subscribers
None

Details

Summary

This Redux field (part of ConnectionInfo inside KeyserverInfo) will now store a RecoveryActionSource instead of just a boolean. This will allow us to pass the RecoveryActionSource from the place where the session recovery is initiated to the place where the session recovery is executed (KeyserverConnectionHandler).

Depends on D11211

Test Plan

I used this test plan for the whole stack: https://gist.github.com/Ashoat/75ab690d5c53cdd68a51b02e03e27c58

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat requested review of this revision.Mar 3 2024, 9:04 PM

Just to make sure: sessionRecoveryInProgress isn't persisted, right?

lib/keyserver-conn/call-keyserver-endpoint-provider.react.js
328 ↗(On Diff #37745)

Nit

lib/types/redux-types.js
1360–1363 ↗(On Diff #37745)

Should we delete this?

This revision is now accepted and ready to land.Mar 4 2024, 1:47 AM

Just to make sure: sessionRecoveryInProgress isn't persisted, right?

That's right – all of ConnectionInfo is not persisted

lib/types/redux-types.js
1360–1363 ↗(On Diff #37745)

Oops yeah, good catch