Page MenuHomePhabricator

[lib][native] Introduce supportingMultipleKeyservers constant
ClosedPublic

Authored by ashoat on Mar 3 2024, 9:07 PM.
Tags
None
Referenced Files
F3361518: D11230.diff
Sun, Nov 24, 5:51 PM
Unknown Object (File)
Tue, Oct 29, 9:48 AM
Unknown Object (File)
Oct 14 2024, 7:11 PM
Unknown Object (File)
Oct 4 2024, 2:46 AM
Unknown Object (File)
Oct 4 2024, 2:46 AM
Unknown Object (File)
Oct 4 2024, 2:46 AM
Unknown Object (File)
Oct 4 2024, 2:46 AM
Unknown Object (File)
Aug 29 2024, 12:25 PM
Subscribers

Details

Summary

Introducing this constant right now even though it's not really doing anything.

As mentioned a couple diffs back, I want this constant introduced so we can be clear on the various distinct launches we'll have in 2024.

The code in SQLiteDataHandler doesn't yet support recovery from a corrupt SQLite database in a multi-keyserver scenario, as this depends on restoring from the backup service.

Question for @michal: is there an existing task tracking implementing backup restore for corrupt database recovery, for both native and web? I want to add a comment referencing this code in SQLiteDataHandler, to make sure it's updated as part of that task.

Depends on D11229

Test Plan

I used this test plan for the whole stack: https://gist.github.com/Ashoat/75ab690d5c53cdd68a51b02e03e27c58

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

is there an existing task tracking implementing backup restore for corrupt database recovery, for both native and web? I want to add a comment referencing this code in SQLiteDataHandler, to make sure it's updated as part of that task.

There is no task in this. I created ENG-7114 : Corrupt SQLite recovery with backup (under ENG-6903 : Backup and app/account lifecycle).

This revision is now accepted and ready to land.Mar 5 2024, 6:32 AM