Page MenuHomePhabricator

[backup service] Revoke log blob holders
ClosedPublic

Authored by michal on Feb 22 2024, 4:37 AM.
Tags
None
Referenced Files
F3378263: D11143.diff
Wed, Nov 27, 9:41 AM
Unknown Object (File)
Wed, Nov 6, 3:24 PM
Unknown Object (File)
Mon, Nov 4, 7:01 PM
Unknown Object (File)
Mon, Nov 4, 8:49 AM
Unknown Object (File)
Fri, Nov 1, 9:10 PM
Unknown Object (File)
Fri, Nov 1, 9:10 PM
Unknown Object (File)
Fri, Nov 1, 9:09 PM
Unknown Object (File)
Fri, Nov 1, 8:47 PM
Subscribers

Details

Summary

My mistake - forgot to add this code to the backup service while adding logs. This diff adds the code to call blob service revoke holder after removing a log. It also improves the holder revoke for backups a bit so that the blob is called inside of the remove_backup_item function and not in the http handler.

Depends on D11142

Test Plan
  • Create a new backup with logs
  • Make sure that the log is stored in blob service (and not inline in dynamodb)
  • Check that the log blob has a holder
  • Delete the backup
  • Check the the log blob no longer has a holder

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 22 2024, 4:46 AM
Harbormaster failed remote builds in B27058: Diff 37436!
This revision is now accepted and ready to land.Feb 23 2024, 3:13 AM