Details

Reviewers

kamil
michal

Commits

rCOMM7c29d8dd6426: [native] Upload secondary device keys when added to list

Summary

After receiving information from primary device about successful device list update, secondary device should perform device keys upload. Then it should be able to start normal authenticated Tunnelbroker session.

Depends on D11294

Test Plan

Repeated test plan from D11294, and also made sure the secondary device keys have been uploaded. Monitored the isAuthorized Tunnelbroker prop - after successful RPC call, it switched to true.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Mar 11 2024, 6:18 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 11 2024, 6:18 AM

bartek added a child revision: D11296: [native] Notify primary device on registration finish.Mar 11 2024, 6:18 AM

Harbormaster failed remote builds in B27425: Diff 37973!Mar 11 2024, 6:32 AM

Rebase

Harbormaster failed remote builds in B27438: Diff 37986!Mar 11 2024, 7:04 AM

bartek edited the summary of this revision. (Show Details)Mar 11 2024, 7:11 AM

bartek edited the test plan for this revision. (Show Details)

Rebase

Harbormaster failed remote builds in B27444: Diff 37992!Mar 11 2024, 7:33 AM

Rebase

Harbormaster completed remote builds in B27465: Diff 38014.Mar 12 2024, 2:04 AM

bartek published this revision for review.Mar 12 2024, 2:19 AM

kamil accepted this revision.Mar 13 2024, 5:52 AM

kamil added inline comments.

native/qr-code/qr-code-screen.react.js
40 ↗	(On Diff #38014)	`deviceKeys` we have this name in multiple places in codebase and different meanings which makes me a bit confusing - would be good to use something more specific but not sure what is the best option
57 ↗	(On Diff #38014)	I think you should use `peerToPeerMessageValidator` here
101 ↗	(On Diff #38014)	I think you can just return `undefined`?