Page MenuHomePhabricator
Differential D11296

[native] Notify primary device on registration finish
ClosedPublic
Actions

Authored by bartek on Mar 11 2024, 6:18 AM.
Tags
None
Referenced Files
F3113710: D11296.id37993.diff
Thu, Oct 31, 6:24 PM
Unknown Object (File)
Sun, Oct 27, 8:20 AM
Unknown Object (File)
Tue, Oct 22, 3:04 PM
Unknown Object (File)
Tue, Oct 22, 3:04 PM
Unknown Object (File)
Tue, Oct 22, 3:04 PM
Unknown Object (File)
Tue, Oct 22, 3:04 PM
Unknown Object (File)
Tue, Oct 22, 3:04 PM
Unknown Object (File)
Tue, Oct 22, 3:04 PM
View All 72 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
michal
Commits
rCOMM91ea52f7fda2: [native] Notify primary device on registration finish
Summary

After successful registration (D11295), secondary device notifies primary device that it has performed device key upload. At this point, primary device can continue (next diffs)

Depends on D11295

Test Plan

An alert is displayed on primary device after successful device keys upload on secondary device

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Mar 11 2024, 6:18 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 11 2024, 6:18 AM
Harbormaster failed remote builds in B27426: Diff 37974!Mar 11 2024, 6:33 AM
bartek updated this revision to Diff 37987.Mar 11 2024, 6:48 AM

Rebase

bartek added a child revision: D11301: [native] Broadcast device list update and send backup key stub.Mar 11 2024, 6:49 AM
Harbormaster failed remote builds in B27439: Diff 37987!Mar 11 2024, 7:06 AM
bartek edited the summary of this revision. (Show Details)Mar 11 2024, 7:13 AM
bartek edited the test plan for this revision. (Show Details)
bartek updated this revision to Diff 37993.Mar 11 2024, 7:20 AM

Rebase

Harbormaster failed remote builds in B27445: Diff 37993!Mar 11 2024, 7:35 AM
bartek updated this revision to Diff 38015.Mar 12 2024, 1:49 AM

Rebase

Harbormaster completed remote builds in B27466: Diff 38015.Mar 12 2024, 2:04 AM
bartek published this revision for review.Mar 12 2024, 2:20 AM
ashoat added inline comments.Mar 12 2024, 3:32 PM
native/qr-code/qr-code-screen.react.js
59

I would apply "De Morgan's Law" here

67

Is this console.log left over from debuggin?

kamil accepted this revision.Mar 13 2024, 5:58 AM

Do we have some alternatives to detect that secondary device auth succeded other than isAuthorized from Tunnelbroker? Wondering if this is the best approach

native/profile/secondary-device-qr-code-scanner.react.js
103

I think you should use peerToPeerMessageValidator here

This revision is now accepted and ready to land.Mar 13 2024, 5:58 AM
bartek added inline comments.Mar 18 2024, 5:09 AM
native/qr-code/qr-code-screen.react.js
67

Yeah, leftover, thanks

bartek updated this revision to Diff 38126.Mar 18 2024, 5:09 AM

Address review feedback

Harbormaster completed remote builds in B27555: Diff 38126.Mar 18 2024, 5:28 AM
Closed by commit rCOMM91ea52f7fda2: [native] Notify primary device on registration finish (authored by bartek). · Explain WhyMar 21 2024, 4:29 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM91ea52f7fda2: [native] Notify primary device on registration finish.

Revision Contents
Changeset List

PathSize
native/
profile/
59 lines
qr-code/
43 lines

Diff 38015

View Options

native/profile/secondary-device-qr-code-scanner.react.js

Loading...
View Options

native/qr-code/qr-code-screen.react.js

Loading...