Page MenuHomePhabricator
Differential D11280

[lib] Add a reducer that handles successful ops processing
ClosedPublic
Actions

Authored by tomek on Mar 8 2024, 1:00 AM.
Tags
None
Referenced Files
F6283908: D11280.id38367.diff
Fri, Apr 25, 8:30 PM
Unknown Object (File)
Sat, Apr 19, 2:06 PM
Unknown Object (File)
Thu, Apr 17, 12:57 AM
Unknown Object (File)
Sun, Mar 30, 2:40 AM
Unknown Object (File)
Sun, Mar 30, 1:41 AM
Unknown Object (File)
Sun, Mar 30, 12:00 AM
Unknown Object (File)
Sat, Mar 29, 11:13 AM
Unknown Object (File)
Fri, Mar 28, 4:19 PM
View All Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
will
Commits
rCOMMbac8331a77bc: [lib] Add a reducer that handles successful ops processing
Summary

Remove the front of the queue when we are noticed that the processing was successful

https://linear.app/comm/issue/ENG-7102/reduce-the-action-this-should-filter-the-ops-out-from-the-array

Depends on D11279

Test Plan

Tests

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Mar 8 2024, 1:00 AM
Herald added a subscriber: ashoat. · View Herald TranscriptMar 8 2024, 1:00 AM
Harbormaster completed remote builds in B27398: Diff 37942.Mar 8 2024, 1:16 AM
tomek requested review of this revision.Mar 8 2024, 1:16 AM
tomek added a child revision: D11281: [lib] Add an optional ID field to all the actions.Mar 8 2024, 2:28 AM
kamil accepted this revision.Mar 11 2024, 4:13 AM
kamil added inline comments.
lib/reducers/db-ops-reducer.js
7 ↗(On Diff #37942)
This revision is now accepted and ready to land.Mar 11 2024, 4:13 AM
tomek updated this revision to Diff 38261.Mar 21 2024, 5:04 AM

Rename, rebase

Harbormaster completed remote builds in B27640: Diff 38261.Mar 21 2024, 5:19 AM
tomek updated this revision to Diff 38266.Mar 21 2024, 8:08 AM

Simplify reducer logic

Harbormaster completed remote builds in B27645: Diff 38266.Mar 21 2024, 8:23 AM
tomek updated this revision to Diff 38367.Mar 27 2024, 8:45 AM

Simplify

tomek edited the summary of this revision. (Show Details)Mar 27 2024, 8:47 AM
Harbormaster completed remote builds in B27704: Diff 38367.Mar 27 2024, 9:01 AM
Closed by commit rCOMMbac8331a77bc: [lib] Add a reducer that handles successful ops processing (authored by tomek). · Explain WhyMar 28 2024, 8:11 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMbac8331a77bc: [lib] Add a reducer that handles successful ops processing.

Revision Contents
Changeset List

PathSize
lib/
reducers/
19 lines
73 lines
2 lines

Diff 38266

View Options

lib/reducers/db-ops-reducer.js

Show First 20 Lines • Show All 69 Lines • ▼ Show 20 Lines if (!isViewer && startsCluster) {
height += authorNameHeight; height += authorNameHeight;
} }
if (endsCluster) { if (endsCluster) {
height += clusterEndHeight; height += clusterEndHeight;
} }
if (textMessageSendFailed(item)) { if (textMessageSendFailed(item)) {
height += failedSendHeight; height += failedSendHeight;
} }
const label = getMessageLabel(item.hasBeenEdited, threadInfo); const label = getMessageLabel(item.hasBeenEdited, threadInfo.id);
if (item.threadCreatedFromMessage || Object.keys(item.reactions).length > 0) { if (item.threadCreatedFromMessage || Object.keys(item.reactions).length > 0) {
height += height +=
inlineEngagementStyle.height + inlineEngagementStyle.height +
inlineEngagementStyle.marginTop + inlineEngagementStyle.marginTop +
inlineEngagementStyle.marginBottom; inlineEngagementStyle.marginBottom;
} else if (label) { } else if (label) {
height += height +=
inlineEngagementLabelStyle.height + inlineEngagementLabelStyle.height +
▲ Show 20 Lines • Show All 367 Lines • Show Last 20 Lines
View Options

lib/reducers/db-ops-reducer.test.js

Show First 20 Lines • Show All 69 Lines • ▼ Show 20 Lines if (!isViewer && startsCluster) {
height += authorNameHeight; height += authorNameHeight;
} }
if (endsCluster) { if (endsCluster) {
height += clusterEndHeight; height += clusterEndHeight;
} }
if (textMessageSendFailed(item)) { if (textMessageSendFailed(item)) {
height += failedSendHeight; height += failedSendHeight;
} }
const label = getMessageLabel(item.hasBeenEdited, threadInfo); const label = getMessageLabel(item.hasBeenEdited, threadInfo.id);
if (item.threadCreatedFromMessage || Object.keys(item.reactions).length > 0) { if (item.threadCreatedFromMessage || Object.keys(item.reactions).length > 0) {
height += height +=
inlineEngagementStyle.height + inlineEngagementStyle.height +
inlineEngagementStyle.marginTop + inlineEngagementStyle.marginTop +
inlineEngagementStyle.marginBottom; inlineEngagementStyle.marginBottom;
} else if (label) { } else if (label) {
height += height +=
inlineEngagementLabelStyle.height + inlineEngagementLabelStyle.height +
▲ Show 20 Lines • Show All 367 Lines • Show Last 20 Lines
View Options

lib/reducers/master-reducer.js

Show First 20 Lines • Show All 69 Lines • ▼ Show 20 Lines if (!isViewer && startsCluster) {
height += authorNameHeight; height += authorNameHeight;
} }
if (endsCluster) { if (endsCluster) {
height += clusterEndHeight; height += clusterEndHeight;
} }
if (textMessageSendFailed(item)) { if (textMessageSendFailed(item)) {
height += failedSendHeight; height += failedSendHeight;
} }
const label = getMessageLabel(item.hasBeenEdited, threadInfo); const label = getMessageLabel(item.hasBeenEdited, threadInfo.id);
if (item.threadCreatedFromMessage || Object.keys(item.reactions).length > 0) { if (item.threadCreatedFromMessage || Object.keys(item.reactions).length > 0) {
height += height +=
inlineEngagementStyle.height + inlineEngagementStyle.height +
inlineEngagementStyle.marginTop + inlineEngagementStyle.marginTop +
inlineEngagementStyle.marginBottom; inlineEngagementStyle.marginBottom;
} else if (label) { } else if (label) {
height += height +=
inlineEngagementLabelStyle.height + inlineEngagementLabelStyle.height +
▲ Show 20 Lines • Show All 367 Lines • Show Last 20 Lines