Paths

Table of Contentst

Differential D11367

[lib] Handle processing of the ops
ClosedPublic
Actions

Authored by tomek on Mar 21 2024, 8:20 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 13, 4:09 AM

	Unknown Object (File)
	Wed, Nov 13, 1:19 AM

	Unknown Object (File)
	Wed, Nov 13, 1:19 AM

	Unknown Object (File)
	Wed, Nov 13, 1:19 AM

	Unknown Object (File)
	Wed, Nov 13, 1:19 AM

	Unknown Object (File)
	Oct 11 2024, 10:34 AM

	Unknown Object (File)
	Oct 11 2024, 10:34 AM

	Unknown Object (File)
	Oct 11 2024, 10:34 AM

View All 66 Files

Subscribers

Details

Reviewers

kamil
inka
will

Commits

rCOMMf6b18846b255: [lib] Handle processing of the ops

Summary

We're processing the actions one by one and report successful processing after it is done.

https://linear.app/comm/issue/ENG-7098/create-a-handler-that-processes-the-ops

Depends on D11366

Test Plan

Added a sleep to the handler after calling processDBStoreOperations and observed in Redux debugger that the ops were processed.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Mar 21 2024, 8:20 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMar 21 2024, 8:20 AM

tomek edited the summary of this revision. (Show Details)Mar 21 2024, 8:21 AM

tomek added a child revision: D11368: [native][web] Remove processing the ops from reducers.Mar 21 2024, 8:23 AM

tomek edited the summary of this revision. (Show Details)Mar 21 2024, 8:28 AM

tomek edited the test plan for this revision. (Show Details)

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 21 2024, 8:31 AM

Harbormaster failed remote builds in B27648: Diff 38269!

Use the new approach

tomek edited the summary of this revision. (Show Details)Mar 27 2024, 8:58 AM

tomek added inline comments.

lib/handlers/db-ops-handler.react.js
22 ↗	(On Diff #38371)	It might happen that some dependencies change but we don't want to call `processDBStoreOperations` again to avoid duplicated processing of the ops.

Harbormaster completed remote builds in B27708: Diff 38371.Mar 27 2024, 9:13 AM

tomek requested review of this revision.Mar 27 2024, 9:13 AM

kamil accepted this revision.Mar 28 2024, 3:49 AM

kamil added inline comments.

lib/handlers/db-ops-handler.react.js
11 ↗	(On Diff #38371)	I think this can be more specific?

This revision is now accepted and ready to land.Mar 28 2024, 3:49 AM

tomek added inline comments.Mar 28 2024, 4:05 AM

lib/handlers/db-ops-handler.react.js
11 ↗	(On Diff #38371)	Yes, this can be. But overall, it is more convenient to make the inputs as general as possible - this makes the API more flexible.

Closed by commit rCOMMf6b18846b255: [lib] Handle processing of the ops (authored by tomek). · Explain WhyMar 28 2024, 8:11 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMf6b18846b255: [lib] Handle processing of the ops.

Revision Contents
Changeset List

Path

Size

lib/

handlers/

db-ops-handler.react.js

28 lines

native/

4 lines

web/

components/

db-ops-handler.react.js

20 lines

2 lines

Diff 38269

lib/handlers/db-ops-handler.react.js

Loading...

native/root.react.js

Loading...

web/components/db-ops-handler.react.js

Loading...

web/root.js

Loading...