We're going to create a new version of UPDATE_RELATIONSHIP which can support the farcaster_mutual action.
Depends on D11381
Paths
| Differential D11382 Authored by atul on Mar 25 2024, 1:31 PM.
Details Summary We're going to create a new version of UPDATE_RELATIONSHIP which can support the farcaster_mutual action. Depends on D11381 Test Plan Straightforward rename. flow + CI
Diff Detail
Event TimelineHerald added a subscriber: tomek. · View Herald TranscriptMar 25 2024, 1:31 PM2024-03-25 13:31:32 (UTC-7) Harbormaster completed remote builds in B27673: Diff 38305.Mar 25 2024, 1:46 PM2024-03-25 13:46:23 (UTC-7) Harbormaster completed remote builds in B27674: Diff 38306.Mar 25 2024, 1:49 PM2024-03-25 13:49:25 (UTC-7) This revision is now accepted and ready to land.Mar 25 2024, 2:15 PM2024-03-25 14:15:20 (UTC-7) This revision was landed with ongoing or failed builds.Mar 26 2024, 12:25 PM2024-03-26 12:25:25 (UTC-7) Closed by commit rCOMM91b21c0873ea: [lib] Rename `UPDATE_RELATIONSHIP` message type to `LEGACY_UPDATE...` (authored by atul). · Explain Why This revision was automatically updated to reflect the committed changes. Harbormaster completed remote builds in B27687: Diff 38342.Mar 26 2024, 12:27 PM2024-03-26 12:27:04 (UTC-7)
Revision Contents
Diff 38306 keyserver/src/updaters/relationship-updaters.js
lib/shared/message-utils.test.js
lib/shared/messages/message-specs.js
lib/shared/messages/update-relationship-message-spec.js
|
This logic is a bit confusing.
I guess the reason we decided to store a separate deviceToken per keyserver is because we want to know if we've shared our deviceToken to that keyserver yet, not because we expect to have a different deviceToken per keyserver.
It would probably make more sense if we have a deviceTokenHasBeenUploaded: boolean in KeyserverInfo, and a deviceToken field at the top level of Redux. But we'll likely end up removing deviceTokens from keyservers soon anyways...