Page MenuHomePhabricator
Differential D11383

[CommCoreModule] MessageSpec changes for updated `UPDATE_RELATIONSHIP`
ClosedPublic
Actions

Authored by atul on Mar 25 2024, 5:57 PM.
Tags
None
Referenced Files
F3354984: D11383.diff
Sat, Nov 23, 1:48 PM
Unknown Object (File)
Sun, Nov 17, 7:25 PM
Unknown Object (File)
Tue, Nov 12, 9:27 PM
Unknown Object (File)
Tue, Nov 12, 9:27 PM
Unknown Object (File)
Tue, Nov 12, 9:27 PM
Unknown Object (File)
Tue, Nov 12, 9:27 PM
Unknown Object (File)
Fri, Nov 1, 10:53 PM
Unknown Object (File)
Fri, Nov 1, 10:53 PM
View All 66 Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
varun
will
Commits
rCOMM190b098d2697: [CommCoreModule] MessageSpec changes for updated `UPDATE_RELATIONSHIP`
Summary

This is effectively https://github.com/CommE2E/comm/commit/3d47f80c594a69206179fd8f33bb57d31b1fd78d and https://github.com/CommE2E/comm/commit/f1debdb595bcba76db8e91ff8d70519b9b0a785b squashed together into a single diff.

We use the same spec for both on the C++ side.

Depends on D11382

Test Plan

Close reading + builds

NOTE: It appears that we're missing a spec for TOGGLE_PIN. This doesn't appear to cause any issues on C++ side since message_specs_initializer is a Map rather than eg std::vector so it's fine that we have a "gap."

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
PersistentStorageUtilities/
MessageOperationsUtilities/
9 lines

Diff 38322

View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/MessageOperationsUtilities/MessageSpecs.h

Loading...