[landing] introduce /connect-farcaster route
ClosedPublic
Actions

Authored by ginsu on Mar 27 2024, 9:19 PM.

Details

Reviewers

atul

Commits

rCOMM1aceccccbaf3: [landing] introduce /connect-farcaster route

Summary

After introducing the ConnectFarcaster component we should implement the necessary routing logic to route to it whenever the url is BASE_LANDING_URL/connect-farcaster

Depends on D11428

Test Plan

Confirmed that I was able to route to BASE_LANDING_URL/connect-farcaster + tested the entire sign in flow during the hackathon

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Mar 27 2024, 9:19 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 27 2024, 9:19 PM

ginsu edited the summary of this revision. (Show Details)Mar 27 2024, 9:20 PM

ginsu added a reviewer: atul.

ginsu edited the summary of this revision. (Show Details)Mar 27 2024, 9:31 PM

ginsu added a parent revision: D11428: [landing] introduce ConnectFarcaster.

ginsu added a child revision: D11432: [landing/lib/native] introduce FarcasterWebView.

Harbormaster completed remote builds in B27748: Diff 38411.Mar 27 2024, 9:34 PM

ginsu requested review of this revision.Mar 27 2024, 9:34 PM

atul accepted this revision.Mar 28 2024, 5:50 AM

This revision is now accepted and ready to land.Mar 28 2024, 5:50 AM

Closed by commit rCOMM1aceccccbaf3: [landing] introduce /connect-farcaster route (authored by ginsu). · Explain WhyMar 28 2024, 10:58 AM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM1aceccccbaf3: [landing] introduce /connect-farcaster route.

Revision Contents
Changeset List

Path

Size

landing/

landing.react.js

6 lines

Diff 38411

View Options

[landing] introduce /connect-farcaster routeClosedPublicActions