Page MenuHomePhabricator
Differential D11435

[protos] Reorder some RPCs
ClosedPublic
Actions

Authored by bartek on Mar 28 2024, 3:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 7, 1:17 PM
Unknown Object (File)
Tue, May 7, 1:17 PM
Unknown Object (File)
Tue, May 7, 1:17 PM
Unknown Object (File)
Apr 13 2024, 9:21 PM
Unknown Object (File)
Apr 10 2024, 10:57 AM
Unknown Object (File)
Apr 9 2024, 10:20 AM
Unknown Object (File)
Apr 6 2024, 12:14 AM
Unknown Object (File)
Apr 5 2024, 10:53 AM
View All 14 Files
Subscribers
tomek

Details

Reviewers
ashoat
varun
Commits
rCOMMe4ead704d6b4: [protos] Reorder some RPCs
Summary

Minor cleanup in proto file structure:

  • Replaced // ... with /* ... */ for group headers to emphasize them over other comments
  • Moved some RPCs between groups
  • This also reordered generated code

I'm open to other comment suggestions as well. I prioritized these because of RPC order affecting codegen

Depends on D11379

Test Plan

N/A

Diff Detail

Repository
rCOMM Comm
Branch
barthap/protos1
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Mar 28 2024, 3:22 AM
bartek held this revision as a draft.
Herald added a subscriber: tomek. · View Herald TranscriptMar 28 2024, 3:22 AM
Harbormaster completed remote builds in B27757: Diff 38421.Mar 28 2024, 3:37 AM
bartek added a child revision: D11465: [protos] Add RPC to log in existing device.Mar 28 2024, 10:41 PM
bartek published this revision for review.Mar 28 2024, 11:05 PM
ashoat accepted this revision.Mar 29 2024, 10:47 AM

Seems reasonable

shared/protos/identity_unauth.proto
40–47

Can we replace "Ashoat's" with "authoritative"?

This revision is now accepted and ready to land.Mar 29 2024, 10:47 AM
bartek updated this revision to Diff 38702.Apr 3 2024, 2:51 AM

Use 'authoritative' where applicable

Harbormaster completed remote builds in B27930: Diff 38702.Apr 3 2024, 3:10 AM
Closed by commit rCOMMe4ead704d6b4: [protos] Reorder some RPCs (authored by bartek). · Explain WhyApr 3 2024, 3:17 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMe4ead704d6b4: [protos] Reorder some RPCs.

Revision Contents
Changeset List

Diff 38421

View Options

shared/protos/identity_auth.proto

Loading...
View Options

shared/protos/identity_unauth.proto

Loading...
View Options

web/protobufs/identity-auth-client.cjs

Loading...
View Options

web/protobufs/identity-auth-client.cjs.flow

Loading...
View Options

web/protobufs/identity-unauth.cjs

Loading...
View Options

web/protobufs/identity-unauth.cjs.flow

Loading...