Page MenuHomePhabricator
Differential D11442

[native] introduce ConnectFarcaster registration screen
ClosedPublic
Actions

Authored by ginsu on Mar 28 2024, 9:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 26, 9:40 PM
Unknown Object (File)
Wed, Nov 13, 12:46 AM
Unknown Object (File)
Tue, Nov 12, 10:55 PM
Unknown Object (File)
Oct 22 2024, 2:44 PM
Unknown Object (File)
Oct 18 2024, 6:25 PM
Unknown Object (File)
Oct 18 2024, 6:25 PM
Unknown Object (File)
Oct 18 2024, 6:25 PM
Unknown Object (File)
Oct 11 2024, 11:16 AM
View All 50 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
Commits
rCOMMc29ed7da457a: [native] introduce ConnectFarcaster registration screen
Summary

This diff introduces the barebones ConnectFarcaster registration screen + all the navigational logic needed for it. Decided to break the full introduction into multiple diffs so that this it is easier to review so subsquent diffs will handle extending this component to match what we had during the hackathon

Depends on D11441

Test Plan

Please see screenshot to see what the screen looks like + tested the entire sign in flow during the hackathon

Screenshot 2024-03-28 at 12.37.35 AM.png (1×1 px, 745 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Mar 28 2024, 9:50 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 28 2024, 9:50 AM
ginsu added inline comments.Mar 28 2024, 9:52 AM
native/account/registration/connect-farcaster.react.js
34

This will be removed in a subsequent diff

43

This will be implemented in a subsequent diff

ginsu edited the summary of this revision. (Show Details)Mar 28 2024, 9:52 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added a reviewer: atul.
ginsu added a parent revision: D11441: [native] introduce FarcasterPrompt.
ginsu attached a referenced file: F1434778: Screenshot 2024-03-28 at 12.37.35 AM.png. (Show Details)
Harbormaster completed remote builds in B27778: Diff 38468.Mar 28 2024, 10:06 AM
ginsu requested review of this revision.Mar 28 2024, 10:06 AM
ginsu updated this revision to Diff 38493.Mar 28 2024, 12:44 PM

update

ginsu added inline comments.Mar 28 2024, 12:45 PM
native/account/registration/connect-farcaster.react.js
32 ↗(On Diff #38493)

This will be removed in a subsequent diff

38 ↗(On Diff #38493)

This will be implemented in a subsequent diff

Harbormaster completed remote builds in B27798: Diff 38493.Mar 28 2024, 1:09 PM
ginsu added a child revision: D11461: [native] add the connect farcaster step into the registration flow.Mar 28 2024, 9:36 PM
atul accepted this revision.Mar 29 2024, 12:31 PM
This revision is now accepted and ready to land.Mar 29 2024, 12:31 PM
Closed by commit rCOMMc29ed7da457a: [native] introduce ConnectFarcaster registration screen (authored by ginsu). · Explain WhyMar 29 2024, 2:20 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMc29ed7da457a: [native] introduce ConnectFarcaster registration screen.

Revision Contents
Changeset List

PathSize
native/
account/
registration/
81 lines
6 lines
navigation/
3 lines

Diff 38468

View Options

native/account/registration/connect-farcaster.react.js

Loading...
View Options

native/account/registration/registration-navigator.react.js

Loading...
View Options

native/navigation/route-names.js

Loading...