Page MenuHomePhabricator
Differential D11462

[native] implement onSuccess callback for ConnectFarcaster registration step
ClosedPublic
Actions

Authored by ginsu on Mar 28 2024, 9:43 PM.
Tags
None
Referenced Files
F3353054: D11462.id38521.diff
Sat, Nov 23, 7:52 AM
F3351830: D11462.diff
Sat, Nov 23, 3:46 AM
Unknown Object (File)
Sat, Nov 16, 5:14 PM
Unknown Object (File)
Tue, Nov 12, 11:38 PM
Unknown Object (File)
Oct 22 2024, 2:44 PM
Unknown Object (File)
Oct 18 2024, 6:25 PM
Unknown Object (File)
Oct 18 2024, 6:25 PM
Unknown Object (File)
Oct 15 2024, 12:20 AM
View All 45 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
Commits
rCOMM196a02b8e0b3: [native] implement onSuccess callback for ConnectFarcaster registration step
Summary

This diff implements the onSuccess callback in the ConnectFarcaster screen. This callback gets called back whenever we successfully get the fid from the farcaster webview

Depends on D11461

Test Plan

Please see the demo video below + tested the entire sign in flow during the hackathon

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Mar 28 2024, 9:43 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 28 2024, 9:43 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 28 2024, 9:45 PM
Harbormaster failed remote builds in B27804: Diff 38521!
ginsu requested review of this revision.Mar 28 2024, 9:47 PM
ginsu edited the summary of this revision. (Show Details)
ginsu edited the test plan for this revision. (Show Details)
ginsu added a reviewer: atul.
ginsu added a parent revision: D11461: [native] add the connect farcaster step into the registration flow.
ginsu attached a referenced file: F1440319: RPReplay_Final1711658857.MP4. (Show Details)

will make sure ci passes before landing

ginsu added a child revision: D11463: [native] introduce already connected button to farcaster connect.Mar 28 2024, 10:08 PM
atul accepted this revision.Mar 29 2024, 1:19 PM
This revision is now accepted and ready to land.Mar 29 2024, 1:19 PM
Harbormaster completed remote builds in B27804: Diff 38521.Mar 29 2024, 2:14 PM
Closed by commit rCOMM196a02b8e0b3: [native] implement onSuccess callback for ConnectFarcaster registration step (authored by ginsu). · Explain WhyMar 29 2024, 2:20 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM196a02b8e0b3: [native] implement onSuccess callback for ConnectFarcaster registration step.

Revision Contents
Changeset List

PathSize
native/
account/
registration/
19 lines
1 line

Diff 38521

View Options

native/account/registration/connect-farcaster.react.js

Loading...
View Options

native/account/registration/registration-types.js

Loading...