[native] Avoid passing in localMediaID to onUploadFailed every time
ClosedPublic
Actions

Authored by ashoat on Mar 29 2024, 12:10 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Sep 18, 1:35 PM

	Unknown Object (File)
	Wed, Sep 18, 8:19 AM

	Unknown Object (File)
	Sun, Sep 8, 6:11 AM

	Unknown Object (File)
	Sun, Sep 8, 6:11 AM

	Unknown Object (File)
	Sun, Sep 8, 4:16 AM

	Unknown Object (File)
	Fri, Aug 30, 10:49 AM

	Unknown Object (File)
	Aug 8 2024, 11:26 PM

	Unknown Object (File)
	Jul 21 2024, 6:08 PM

View All 35 Files

Subscribers

tomek

Details

Reviewers

atul
bartek

Commits

rCOMM0b5e3cf676b0: [native] Avoid passing in localMediaID to onUploadFailed every time

Summary

This is a simple no-op refactor that simplifies the code a little bit.

Depends on D11475

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Mar 29 2024, 12:10 PM

Herald added a subscriber: tomek. · View Herald TranscriptMar 29 2024, 12:10 PM

ashoat added a child revision: D11477: [native] Make thumbnail failed when main upload fails.Mar 29 2024, 12:12 PM

Harbormaster completed remote builds in B27823: Diff 38545.Mar 29 2024, 12:26 PM

ashoat requested review of this revision.Mar 29 2024, 12:26 PM

atul accepted this revision.Mar 29 2024, 12:26 PM

This revision is now accepted and ready to land.Mar 29 2024, 12:26 PM

Closed by commit rCOMM0b5e3cf676b0: [native] Avoid passing in localMediaID to onUploadFailed every time (authored by ashoat). · Explain WhyMar 29 2024, 12:48 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM0b5e3cf676b0: [native] Avoid passing in localMediaID to onUploadFailed every time.

Revision Contents
Changeset List

Path

Size

native/

input/

input-state-container.react.js

14 lines

Diff 38545

View Options

native/input/input-state-container.react.js

[native] Avoid passing in localMediaID to onUploadFailed every timeClosedPublicActions