Page MenuHomePhabricator

[native] update FarcasterPrompt based on if the fid is set or not
ClosedPublic

Authored by ginsu on Mar 29 2024, 2:37 PM.
Tags
None
Referenced Files
F3376181: D11484.id38565.diff
Tue, Nov 26, 10:30 PM
F3375413: D11484.diff
Tue, Nov 26, 8:05 PM
Unknown Object (File)
Sat, Nov 23, 1:11 PM
Unknown Object (File)
Sat, Nov 23, 6:53 AM
Unknown Object (File)
Wed, Nov 13, 12:45 AM
Unknown Object (File)
Tue, Nov 12, 10:55 PM
Unknown Object (File)
Oct 22 2024, 2:44 PM
Unknown Object (File)
Oct 18 2024, 6:25 PM
Subscribers

Details

Summary

This diff updates the text content of FarcasterPrompt based on wheter or not the user is logged into farcaster or not (we determine this by whether or not the comm user has an fid set)

Depends on D11483

Test Plan

Please see the screenshots below

When fid is set:

IMG_6793.PNG (2×1 px, 112 KB)

When fid is not set:

IMG_6792.PNG (2×1 px, 137 KB)

Confirmed that these changes to FarcasterPrompt do NOT affect the registration flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu requested review of this revision.Mar 29 2024, 2:52 PM

Will this affect the experience when FarcasterPrompt is used from the registration flow?

Will this affect the experience when FarcasterPrompt is used from the registration flow?

No, we set the fid only at the very end of the registration flow so the text content will only change in the context of the Farcaster account settings screen. I will make sure that my test plan shows this

ginsu requested review of this revision.Apr 1 2024, 12:09 PM
ginsu edited the summary of this revision. (Show Details)
ginsu edited the test plan for this revision. (Show Details)
ginsu added a reviewer: atul.
ginsu attached a referenced file: F1452475: IMG_6792.PNG. (Show Details)
ginsu attached a referenced file: F1452474: IMG_6793.PNG. (Show Details)
ginsu added a reviewer: ashoat.

Making @ashoat blocking reviewer since this diff does have copy changes

Looks fine outside of copy being signed off on

native/components/farcaster-prompt.react.js
14

I'd match capitalization and do fidContext is missing but up to you

This revision is now accepted and ready to land.Apr 2 2024, 12:26 PM

rebase before landing + make sure keyserver build ci works

This diff actually did end up affecting the registration flow. It introduced a very slight regression due to @ginsu's removal of the question mark. @ginsu, can you reply here either with a diff that fixes it, or a task?

This diff actually did end up affecting the registration flow. It introduced a very slight regression due to @ginsu's removal of the question mark. @ginsu, can you reply here either with a diff that fixes it, or a task?

My bad! thanks for catching this! D11621 should fix this issue