Details

Reviewers

Commits

rCOMMaf0bb9f6dfcf: [native] introduce farcaster account settings profile row

Summary

this diff introduces a barebones FarcasterAccountSettings screen + all the navigational logic to get to this screen from the profiles screen. Too make this diff easier to review, subsequent diffs will handle extending FarcasterAccountSettings.

Depends on D11463

Test Plan

Please see the demo video below + tested the entire sign in + unauth flow during the hackathon

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Mar 29 2024, 2:29 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 29 2024, 2:29 PM

ginsu edited the summary of this revision. (Show Details)Mar 29 2024, 2:32 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added a reviewer: atul.

ginsu added a parent revision: D11463: [native] introduce already connected button to farcaster connect.

ginsu added inline comments.

native/profile/profile-screen.react.js
204–209 ↗	(On Diff #38564)	This code lives in a class component, so that is why we are not using `useMemo()` here

ginsu edited the test plan for this revision. (Show Details)Mar 29 2024, 2:35 PM

ginsu attached a referenced file: F1442433: Screen Recording 2024-03-29 at 5.35.12 PM.mov. (Show Details)

ginsu added inline comments.Mar 29 2024, 2:37 PM

native/profile/profile-screen.react.js
176 ↗	(On Diff #38564)	Decided to gate `farcasterAccountSettings` behind the `staffCanSee` so that we can internally test this before releasing this to the public

Harbormaster completed remote builds in B27831: Diff 38564.Mar 29 2024, 2:45 PM

ginsu requested review of this revision.Mar 29 2024, 2:45 PM

ashoat added inline comments.Mar 30 2024, 12:59 PM

native/profile/profile-screen.react.js
176 ↗	(On Diff #38564)	I think we're gating it in two other places based on `usingCommServicesAccessToken`: `FarcasterDataHandler` The new registration flow, which contains the farcaster registration flow Should we do the same here?

ginsu added inline comments.Apr 1 2024, 11:56 AM

native/profile/profile-screen.react.js
176 ↗	(On Diff #38564)	yea that makes sense, I'll update the gate so that it's based off of `usingCommServicesAccessToken` + `__DEV__` rather than `staffCanSee`