Page MenuHomePhabricator
Differential D11480

[native] Turn migration 64 into noop
ClosedPublic
Actions

Authored by atul on Mar 29 2024, 1:12 PM.
Tags
None
Referenced Files
F2833466: D11480.diff
Sat, Sep 28, 8:06 AM
Unknown Object (File)
Wed, Sep 18, 8:18 AM
Unknown Object (File)
Sun, Sep 8, 6:12 AM
Unknown Object (File)
Sun, Sep 8, 6:12 AM
Unknown Object (File)
Sun, Sep 8, 6:11 AM
Unknown Object (File)
Sun, Sep 8, 4:16 AM
Unknown Object (File)
Aug 9 2024, 5:22 AM
Unknown Object (File)
Aug 9 2024, 12:51 AM
View All 47 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
will
varun
Commits
rCOMM36123e7fb7db: [native] Turn migration 64 into noop
Summary

To unblock release without flipping switch on specialRole work.

Test Plan

NA, will re-introduce as migration 66 or something shortly.

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D11480 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Mar 29 2024, 1:12 PM
atul published this revision for review.Mar 29 2024, 1:16 PM
Harbormaster completed remote builds in B27827: Diff 38554.Mar 29 2024, 1:28 PM
ashoat accepted this revision.Mar 29 2024, 1:56 PM

It would be good to add some more context on why we're doing it, either as a comment in the code, or at least here

This revision is now accepted and ready to land.Mar 29 2024, 1:56 PM
atul updated this revision to Diff 38644.Apr 1 2024, 8:51 PM

add explanation

Harbormaster failed remote builds in B27900: Diff 38644!Apr 1 2024, 8:54 PM
Harbormaster completed remote builds in B27900: Diff 38644.Apr 2 2024, 7:38 AM
Closed by commit rCOMM36123e7fb7db: [native] Turn migration 64 into noop (authored by atul). · Explain WhyApr 2 2024, 10:25 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM36123e7fb7db: [native] Turn migration 64 into noop.

Revision Contents
Changeset List

PathSize
native/
redux/
12 lines

Diff 38644

View Options

native/redux/persist.js

Loading...