Page MenuHomePhabricator
Differential D11530

[scripts] Improve prompt
ClosedPublic
Actions

Authored by inka on Apr 3 2024, 1:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 22, 3:46 AM
Unknown Object (File)
Thu, Apr 10, 11:06 AM
Unknown Object (File)
Thu, Apr 10, 2:30 AM
Unknown Object (File)
Thu, Apr 10, 1:50 AM
Unknown Object (File)
Wed, Apr 9, 11:26 PM
Unknown Object (File)
Wed, Apr 9, 4:45 AM
Unknown Object (File)
Mar 21 2025, 11:02 PM
Unknown Object (File)
Mar 21 2025, 1:16 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
will
kamil
Commits
rCOMM99d77585156c: [scripts] Improve prompt
Summary

issue: ENG-7310
The admin of the new keyserver has to be a user that was not an admin befroe. They don't have to exist on the identity service though, registration will be attempted

Test Plan

Ran nix develop, typed y and checked that the propmt is printed correctly

Diff Detail

Repository
rCOMM Comm
Branch
inka/followupts_to_testing
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Apr 3 2024, 1:49 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 3 2024, 1:49 AM
Harbormaster completed remote builds in B27927: Diff 38699.Apr 3 2024, 2:05 AM
inka requested review of this revision.Apr 3 2024, 2:05 AM
tomek added inline comments.Apr 3 2024, 2:10 AM
scripts/set-user-credentials.js
30
kamil resigned from this revision.Apr 3 2024, 5:17 AM

LGTM but leaving final review to native speaker

scripts/set-user-credentials.js
32
inka added a child revision: D11540: [keyserver] Refactor registerOrLogIn to take callbacks.Apr 3 2024, 6:36 AM
will accepted this revision.Apr 3 2024, 12:42 PM

Prompt reads pretty clear to me

scripts/set-user-credentials.js
31
This revision is now accepted and ready to land.Apr 3 2024, 12:42 PM
inka updated this revision to Diff 38767.Apr 4 2024, 5:36 AM

Address review

Harbormaster completed remote builds in B27970: Diff 38767.Apr 4 2024, 5:52 AM
Closed by commit rCOMM99d77585156c: [scripts] Improve prompt (authored by inka). · Explain WhyApr 5 2024, 5:58 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM99d77585156c: [scripts] Improve prompt.

Revision Contents
Changeset List

PathSize
scripts/
8 lines

Diff 38699

View Options

scripts/set-user-credentials.js

  • This file was added.
// flow-typed signature: 585e2883477434dc7cfd534337e85dce
// flow-typed version: <<STUB>>/viem_v2.9.5/flow_v0.202.1
declare module 'viem' {
declare export type ViemTransport = { ... };
declare export function http(url?: string): ViemTransport;
declare export type ViemChain = { ... };
declare export type ViemCreateClientParams = {
+chain: ViemChain,
+transport: ViemTransport,
...
};
declare export type ViemClient = {
...
};
declare export function createClient(
params: ViemCreateClientParams,
): ViemClient;
}
declare module 'view/chains' {
import type { ViemChain } from 'viem';
declare export var mainnet: ViemChain;
declare export var sepolia: ViemChain;
}