Page MenuHomePhabricator
Differential D11512

[native] build out UI for farcaster account settings screen
ClosedPublic
Actions

Authored by ginsu on Apr 1 2024, 12:15 PM.
Tags
None
Referenced Files
F3375298: D11512.diff
Tue, Nov 26, 7:32 PM
Unknown Object (File)
Wed, Nov 13, 12:45 AM
Unknown Object (File)
Tue, Nov 12, 10:55 PM
Unknown Object (File)
Oct 22 2024, 2:44 PM
Unknown Object (File)
Oct 18 2024, 6:25 PM
Unknown Object (File)
Oct 18 2024, 6:25 PM
Unknown Object (File)
Oct 18 2024, 6:25 PM
Unknown Object (File)
Oct 18 2024, 6:25 PM
View All 75 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
Commits
rCOMM00a8b91431f3: [native] build out UI for farcaster account settings screen
Summary

This diff further extends the farcaster account settings screen by implmenting the UI for this screen. To make sure this diff was not too difficult to review, I broke this diff up into two where the next diff will handle unauthing from farcaster

Depends on D11484

Test Plan

Please see the screenshots below + tested the entire sign in + unauth flow during the hackathon

not connected to farcaster:

IMG_6792.PNG (2×1 px, 137 KB)

connected to farcaster:

IMG_6793.PNG (2×1 px, 112 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Apr 1 2024, 12:15 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 1 2024, 12:15 PM
ginsu updated this revision to Diff 38636.Apr 1 2024, 12:18 PM

update

ginsu edited the summary of this revision. (Show Details)Apr 1 2024, 12:21 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added a reviewer: atul.
ginsu added a parent revision: D11484: [native] update FarcasterPrompt based on if the fid is set or not.
ginsu attached a referenced file: F1452563: IMG_6793.PNG. (Show Details)
ginsu attached a referenced file: F1452562: IMG_6792.PNG. (Show Details)
ginsu edited the test plan for this revision. (Show Details)
Harbormaster failed remote builds in B27893: Diff 38635!Apr 1 2024, 12:27 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 1 2024, 12:30 PM
Harbormaster failed remote builds in B27894: Diff 38636!
ginsu added a child revision: D11513: [native] unauth from farcaster.Apr 1 2024, 12:34 PM
ginsu updated this revision to Diff 38639.Apr 1 2024, 12:36 PM

fix ci issues

Harbormaster completed remote builds in B27897: Diff 38639.Apr 1 2024, 12:52 PM
ginsu requested review of this revision.Apr 1 2024, 12:52 PM
atul accepted this revision.Apr 1 2024, 1:12 PM
atul added inline comments.
native/profile/farcaster-account-settings.react.js
55–70 ↗(On Diff #38639)

I'd maybe prefer ternary for each prop since we're using the same ones in both situations, but totally up to you.

This revision is now accepted and ready to land.Apr 1 2024, 1:12 PM
ginsu updated this revision to Diff 38740.Apr 3 2024, 9:25 AM

rebase before landing

Harbormaster completed remote builds in B27960: Diff 38740.Apr 3 2024, 9:41 AM
Closed by commit rCOMM00a8b91431f3: [native] build out UI for farcaster account settings screen (authored by ginsu). · Explain WhyApr 3 2024, 9:49 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM00a8b91431f3: [native] build out UI for farcaster account settings screen.

Revision Contents
Changeset List

PathSize
native/
profile/
97 lines

Diff 38740

View Options

native/profile/farcaster-account-settings.react.js

Loading...