Details
Details
- Everything compiles
- Updated unit and integration tests
- Tested QR Auth on native and web
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- barthap/protos1
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/qr-code/qr-code-screen.react.js | ||
|---|---|---|
| 58 | Interesting that we're changing the approach here and signing the nonce directly instead of signing JSON.stringify({ nonce }) | |
| native/qr-code/qr-code-screen.react.js | ||
|---|---|---|
| 58 | I interpreted that task to be about the proto format. Not sure where we decided about the string that gets signed (nonce vs. JSON.stringify({ nonce })) It's probably not very important. My first thought was that the JSON.stringify({ nonce }) is more flexible if we want to change the format. But then I considered that changing the format wouldn't be that hard anyways, since this nonce is only used in an ephemeral way, to validate the session. | |