Page MenuHomePhabricator
Differential D11553

[lib][web][native] Remove nextLocalID from redux
ClosedPublic
Actions

Authored by inka on Apr 4 2024, 7:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 3, 2:09 AM
Unknown Object (File)
Tue, Oct 22, 2:46 PM
Unknown Object (File)
Tue, Oct 22, 2:46 PM
Unknown Object (File)
Tue, Oct 22, 2:46 PM
Unknown Object (File)
Tue, Oct 22, 2:46 PM
Unknown Object (File)
Tue, Oct 22, 2:46 PM
Unknown Object (File)
Oct 11 2024, 11:49 AM
Unknown Object (File)
Sep 18 2024, 3:45 AM
View All 56 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
ginsu
Commits
rCOMM5e92d20068ea: [lib][web][native] Remove nextLocalID from redux
Summary

issue: ENG-6076
This field is nolonger used after D11552

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Branch
inka/nextLocalID
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Apr 4 2024, 7:19 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 4 2024, 7:19 AM
inka added a parent revision: D11552: [lib][web][native] Use uuid for next local id.Apr 4 2024, 7:20 AM
Harbormaster completed remote builds in B27976: Diff 38773.Apr 4 2024, 7:33 AM
inka requested review of this revision.Apr 4 2024, 7:33 AM
michal accepted this revision.Apr 4 2024, 8:07 AM
michal added inline comments.
native/redux/state-types.js
66 ↗(On Diff #38773)

Don't we need a migration to remove it so we don't get the alert with the unexpected key rehydrated? Or is it fine?

This revision is now accepted and ready to land.Apr 4 2024, 8:07 AM
inka updated this revision to Diff 38779.Apr 4 2024, 9:02 AM

Add migration

Harbormaster completed remote builds in B27977: Diff 38779.Apr 4 2024, 9:18 AM
inka updated this revision to Diff 38845.Apr 5 2024, 3:09 AM

Rebase

inka added a child revision: D11564: [lib] Fix sorting local messages.Apr 5 2024, 3:28 AM
Harbormaster completed remote builds in B28018: Diff 38845.Apr 5 2024, 3:38 AM
Closed by commit rCOMM5e92d20068ea: [lib][web][native] Remove nextLocalID from redux (authored by inka). · Explain WhyApr 5 2024, 3:43 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM5e92d20068ea: [lib][web][native] Remove nextLocalID from redux.

Revision Contents
Changeset List

PathSize
lib/
reducers/
2 lines
types/
1 line
utils/
3 lines
native/
redux/
1 line
6 lines
2 lines
web/
redux/
1 line
2 lines

Diff 38779

View Options

lib/reducers/local-id-reducer.js

Loading...
View Options

lib/reducers/master-reducer.js

Loading...
View Options

lib/types/redux-types.js

Loading...
View Options

lib/utils/reducers-utils.test.js

Loading...
View Options

native/redux/default-state.js

Loading...
View Options

native/redux/persist.js

Loading...
View Options

native/redux/state-types.js

Loading...
View Options

web/redux/default-state.js

Loading...
View Options

web/redux/redux-setup.js

Loading...