Page MenuHomePhabricator

[native] update session creation code to handle versioning
ClosedPublic

Authored by kamil on Apr 8 2024, 7:46 AM.
Tags
None
Referenced Files
F3380985: D11591.id39045.diff
Thu, Nov 28, 3:29 AM
F3380731: D11591.diff
Thu, Nov 28, 1:48 AM
Unknown Object (File)
Sun, Nov 3, 8:12 AM
Unknown Object (File)
Oct 12 2024, 10:23 PM
Unknown Object (File)
Oct 12 2024, 10:23 PM
Unknown Object (File)
Oct 12 2024, 10:23 PM
Unknown Object (File)
Oct 12 2024, 10:23 PM
Unknown Object (File)
Oct 12 2024, 10:23 PM
Subscribers

Details

Summary

This code:

  1. Updates contentInboundSessionCreator to decide whether to accept new or keep old session depending on sessionVersion
  2. Updates contentOutboundSessionCreator to return the session version (right now by default we override session and bump counter).

Depends on D11586

Test Plan
  1. Make sure session creation works
  2. Outbound session creation cause bumping counter
  3. Inbound session creation success or throw an appropriate error (tested all cases)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Apr 9 2024, 6:02 AM
kamil added inline comments.
native/cpp/CommonCpp/CryptoTools/CryptoModule.cpp
265 ↗(On Diff #38919)

handling this param is changed in D11595 - in this diff can be ignored

This revision is now accepted and ready to land.Apr 10 2024, 8:35 AM