Rename addSyncedMetadata and removeSyncedMetadata action types to set and clear
ClosedPublic
Actions

Authored by will on Apr 11 2024, 6:21 AM.

Details

Reviewers

atul
ginsu

Commits

rCOMM340733ee63e9: Rename addSyncedMetadata and removeSyncedMetadata action types to set and clear

Summary

Thought this naming convention was cleaner. Matching the naming convention of operations on our other metadata data type.

Depends on D11626

Test Plan

flow check

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

will created this revision.Apr 11 2024, 6:21 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 11 2024, 6:21 AM

will edited the summary of this revision. (Show Details)Apr 11 2024, 6:34 AM

will added a parent revision: D11626: [lib] have landing send `fid` as a string and not a number.

will added a child revision: D11628: [lib] Make synced metadata name field an enum.

Harbormaster completed remote builds in B28153: Diff 39027.Apr 11 2024, 6:39 AM

will requested review of this revision.Apr 11 2024, 6:39 AM

atul accepted this revision.Apr 12 2024, 1:18 AM

This revision is now accepted and ready to land.Apr 12 2024, 1:18 AM

Closed by commit rCOMM340733ee63e9: Rename addSyncedMetadata and removeSyncedMetadata action types to set and clear. · Explain WhyApr 17 2024, 4:24 AM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM340733ee63e9: Rename addSyncedMetadata and removeSyncedMetadata action types to set and clear.

Revision Contents
Changeset List

Path

Size

lib/

actions/

synced-metadata-actions.js

9 lines

reducers/

synced-metadata-reducer.js

8 lines

types/

redux-types.js

12 lines

synced-metadata-types.js

4 lines

Diff 39169

View Options

lib/actions/synced-metadata-actions.js

View Options

lib/reducers/synced-metadata-reducer.js

View Options

lib/types/redux-types.js

View Options

lib/types/synced-metadata-types.js

Rename addSyncedMetadata and removeSyncedMetadata action types to set and clearClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 39169

lib/actions/synced-metadata-actions.js

lib/reducers/synced-metadata-reducer.js

lib/types/redux-types.js

lib/types/synced-metadata-types.js

Rename addSyncedMetadata and removeSyncedMetadata action types to set and clear
ClosedPublic
Actions

Revision Contents
Changeset List