Page MenuHomePhabricator

[web][native] mark keys as published before uploading to identity service
AbandonedPublic

Authored by varun on Apr 26 2024, 12:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 15 2024, 5:38 AM
Unknown Object (File)
Oct 14 2024, 9:10 PM
Unknown Object (File)
Oct 14 2024, 9:09 PM
Unknown Object (File)
Oct 14 2024, 9:09 PM
Unknown Object (File)
Sep 29 2024, 2:34 PM
Unknown Object (File)
Sep 7 2024, 11:06 AM
Unknown Object (File)
Sep 6 2024, 11:54 PM
Unknown Object (File)
Sep 6 2024, 10:43 PM
Subscribers

Details

Summary

On web and native, we should make sure we mark prekeys/otks as published right before uploading them to the identity service to prevent a scenario where identity is vending keys that haven't been published by the client

Depends on D11810

Test Plan

will attach gist shortly

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat requested changes to this revision.Apr 27 2024, 6:08 PM

Worth reading my comment in the preceding diff before proceeding here. It looks like this diff only moves around calls to mark prekeys as published, which I think should actually stay where they are (after publishing to identity). Might be best to abandon this diff, but let me know if I'm missing something