Paths

Table of Contentst

Differential D12000

[native/web] make `findUserIdentities` RPC available to native and web
ClosedPublic
Actions

Authored by will on May 10 2024, 9:51 PM.

Tags

None

Referenced Files

	F3389125: D12000.id40256.diff
	Fri, Nov 29, 5:39 PM

	F3388764: D12000.diff
	Fri, Nov 29, 3:53 PM

	Unknown Object (File)
	Fri, Nov 8, 8:07 PM

	Unknown Object (File)
	Wed, Nov 6, 8:03 AM

	Unknown Object (File)
	Oct 17 2024, 12:43 PM

	Unknown Object (File)
	Oct 17 2024, 12:43 PM

	Unknown Object (File)
	Oct 17 2024, 12:43 PM

	Unknown Object (File)
	Oct 17 2024, 12:43 PM

Subscribers

Details

Reviewers

bartek
kamil

Commits

rCOMMfb67cd1ec8a1: [native/web] make `findUserIdentities` RPC available to native and web

Summary

Implements FindUserIdentities RPC for web and native

Depends on D11999

Test Plan

On both web/native successfully called the FindUserIdentities rpc on

ethereum user
username user
user with farcaster id
non-existent user (resulting in no entry in the identities result)

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.May 10 2024, 9:51 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 10 2024, 9:51 PM

remove Object from ethereum identity validator

Harbormaster completed remote builds in B28851: Diff 40092.May 10 2024, 10:07 PM

Harbormaster completed remote builds in B28852: Diff 40093.May 10 2024, 10:15 PM

will requested review of this revision.May 10 2024, 10:15 PM

ashoat added inline comments.May 12 2024, 7:02 PM

lib/types/identity-service-types.js
244 ↗	(On Diff #40093)	We generally type `farcasterID` instead of `farcasterId`. Is there a way to do that here?

will added a child revision: D12011: [lib] dispatch actions and populate aux user store with fids.May 12 2024, 8:10 PM

bartek mentioned this in D11998: [native] implement 'FindUserIdentities' RPC in `native_rust_library`.May 13 2024, 12:12 AM

bartek added inline comments.May 13 2024, 12:16 AM

lib/types/identity-service-types.js
244 ↗	(On Diff #40093)	On native there is, added a comment: https://phab.comm.dev/D11998#inline-71174 But for web, we need to do a manual rename in the `forEach()` call in L633

bartek added a subscriber: inka.May 13 2024, 6:47 AM

Planning changes to address Ashoat's comment on changing farcasterId to farcasterID

use farcasterID instead of farcasterID on native/web

Harbormaster completed remote builds in B28926: Diff 40200.May 14 2024, 11:39 PM

Looks good but I wasn't reviewing previous diffs in the stack so letting @bartek do the final approval on whether type definitions and API usage are correct

Looks good now

This revision is now accepted and ready to land.May 15 2024, 12:24 AM

rebase before landing

rebase

Harbormaster failed remote builds in B28961: Diff 40257!May 15 2024, 12:31 PM

Harbormaster completed remote builds in B28960: Diff 40256.

rebase

Harbormaster failed remote builds in B28968: Diff 40265!May 15 2024, 7:46 PM

rebase

Harbormaster completed remote builds in B28970: Diff 40267.May 15 2024, 8:17 PM

Closed by commit rCOMMfb67cd1ec8a1: [native/web] make `findUserIdentities` RPC available to native and web (authored by will). · Explain WhyMay 15 2024, 8:30 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMMfb67cd1ec8a1: [native/web] make `findUserIdentities` RPC available to native and web.

Revision Contents
Changeset List

Path

Size

lib/

types/

identity-service-types.js

32 lines

native/

identity-service/

identity-service-context-provider.react.js

16 lines

web/

grpc/

identity-service-client-wrapper.js

24 lines

identity-service-context-provider.react.js

1 line

Diff 40092

lib/types/identity-service-types.js

Loading...

native/identity-service/identity-service-context-provider.react.js

Loading...

web/grpc/identity-service-client-wrapper.js

Loading...

web/grpc/identity-service-context-provider.react.js

Loading...