Page MenuHomePhabricator

[native/web] make `findUserIdentities` RPC available to native and web
ClosedPublic

Authored by will on May 10 2024, 9:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 8:07 PM
Unknown Object (File)
Wed, Nov 6, 8:03 AM
Unknown Object (File)
Oct 17 2024, 12:43 PM
Unknown Object (File)
Oct 17 2024, 12:43 PM
Unknown Object (File)
Oct 17 2024, 12:43 PM
Unknown Object (File)
Oct 17 2024, 12:43 PM
Unknown Object (File)
Oct 17 2024, 12:43 PM
Unknown Object (File)
Oct 17 2024, 12:43 PM
Subscribers

Details

Summary

Implements FindUserIdentities RPC for web and native

Depends on D11999

Test Plan

On both web/native successfully called the FindUserIdentities rpc on

  1. ethereum user
  2. username user
  3. user with farcaster id
  4. non-existent user (resulting in no entry in the identities result)

Diff Detail

Repository
rCOMM Comm
Branch
farcaster/set_aux_user_fids
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

remove Object from ethereum identity validator

will requested review of this revision.May 10 2024, 10:15 PM
lib/types/identity-service-types.js
244

We generally type farcasterID instead of farcasterId. Is there a way to do that here?

lib/types/identity-service-types.js
244

On native there is, added a comment: https://phab.comm.dev/D11998#inline-71174

But for web, we need to do a manual rename in the forEach() call in L633

will planned changes to this revision.May 13 2024, 3:44 PM

Planning changes to address Ashoat's comment on changing farcasterId to farcasterID

use farcasterID instead of farcasterID on native/web

Looks good but I wasn't reviewing previous diffs in the stack so letting @bartek do the final approval on whether type definitions and API usage are correct

This revision is now accepted and ready to land.May 15 2024, 12:24 AM