Differential D12109

[native][web] Fetch AES key and device ID in parallel in generateQRCode
ClosedPublic
Actions

Authored by ashoat on May 20 2024, 3:54 AM.

Details

Reviewers

bartek

Commits

rCOMM42ab4fd17086: [native][web] Fetch AES key and device ID in parallel in generateQRCode

Summary

Also removed an unnecessary check on the device ID being set, since the Flow types indicate it should always be set.

Depends on D12108

Test Plan

I tested the flow using staging, with my phone as a primary device and a local simulator as a secondary device

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.May 20 2024, 3:54 AM

Herald added a subscriber: tomek. · View Herald TranscriptMay 20 2024, 3:54 AM

ashoat added a child revision: D12110: [web] Rename deviceKeys to qrData in QRCodeLogin.May 20 2024, 3:55 AM

Harbormaster completed remote builds in B29046: Diff 40383.May 20 2024, 4:10 AM

ashoat requested review of this revision.May 20 2024, 4:10 AM

bartek accepted this revision.May 20 2024, 5:37 AM

This revision is now accepted and ready to land.May 20 2024, 5:37 AM

Closed by commit rCOMM42ab4fd17086: [native][web] Fetch AES key and device ID in parallel in generateQRCode (authored by ashoat). · Explain WhyMay 21 2024, 1:11 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM42ab4fd17086: [native][web] Fetch AES key and device ID in parallel in generateQRCode.

Revision Contents
Changeset List

Path

Size

native/

qr-code/

qr-code-screen.react.js

11 lines

web/

account/

qr-code-login.react.js

10 lines

Diff 40383

View Options

native/qr-code/qr-code-screen.react.js