Page MenuHomePhabricator
Differential D12123

[native] Handle outdated client error in QR code auth flow
ClosedPublic
Actions

Authored by ashoat on May 20 2024, 6:43 AM.
Tags
None
Referenced Files
F6244431: D12123.diff
Fri, Apr 25, 1:43 AM
Unknown Object (File)
Mon, Apr 21, 2:29 AM
Unknown Object (File)
Sun, Mar 30, 2:05 PM
Unknown Object (File)
Fri, Mar 28, 11:32 PM
Unknown Object (File)
Mar 21 2025, 6:15 AM
Unknown Object (File)
Feb 27 2025, 11:10 PM
Unknown Object (File)
Feb 26 2025, 8:02 AM
Unknown Object (File)
Feb 26 2025, 8:02 AM
View All 70 Files
Subscribers
tomek

Details

Reviewers
bartek
Commits
rCOMMa00d4c26e2b8: [native] Handle outdated client error in QR code auth flow
Summary

I originally noticed that the QR code flow didn't handle this error when investigating ENG-8113. That led to the further realization that the QR code flow hasn't been kept up-to-date, which was addressed in ENG-8123. This diff completes the circle and finally adds code to handle the outdated client error specifically.

Depends on D12116

Test Plan

I tested the web equivalent by hardcoding a failure in keyserver/src/session/version.js for all web clients

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
qr-code/
23 lines

Diff 40403

View Options

native/qr-code/qr-code-screen.react.js

This file contains generated code, which does not normally need to be reviewed. Show File Contents