Paths

Table of Contentst

Differential D12127

[protos][identity] Add username to AuthResponse
ClosedPublic
Actions

Authored by bartek on May 20 2024, 7:14 AM.

Tags

None

Referenced Files

	F3372399: D12127.id40415.diff
	Tue, Nov 26, 6:26 AM

	F3371382: D12127.diff
	Tue, Nov 26, 4:44 AM

	Unknown Object (File)
	Mon, Nov 25, 6:12 AM

	Unknown Object (File)
	Wed, Nov 13, 6:42 AM

	Unknown Object (File)
	Mon, Nov 11, 12:17 PM

	Unknown Object (File)
	Mon, Nov 11, 8:13 AM

	Unknown Object (File)
	Sun, Nov 10, 10:07 PM

	Unknown Object (File)
	Sat, Nov 9, 10:32 PM

Subscribers

Details

Reviewers

varun
will
ashoat

Commits

rCOMMcdb9ee89587b: [protos][identity] Add username to AuthResponse

Summary

Address ENG-8137.

It turns out to be simple to add username to the AuthResponse on Identity side.
On proto/RPC side, this is also backwards compatible from both sides. If the response doesn't contain username field (client has newer version than deployed Identity Service), it will be defaulted to empty string.

Test Plan

Tested together with D12134 - verified AuthResponse to contain a username in all registration and login RPCs

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.May 20 2024, 7:14 AM

bartek held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptMay 20 2024, 7:14 AM

Harbormaster completed remote builds in B29066: Diff 40415.May 20 2024, 7:31 AM

bartek added a child revision: D12134: [native] Process username received in AuthResponse.May 20 2024, 11:01 PM

bartek published this revision for review.May 21 2024, 12:25 AM

bartek edited the test plan for this revision. (Show Details)

Proto and JS changes look good! Resigning to let somebody else look at Rust changes

varun accepted this revision.May 21 2024, 1:58 AM

This revision is now accepted and ready to land.May 21 2024, 1:58 AM

Closed by commit rCOMMcdb9ee89587b: [protos][identity] Add username to AuthResponse (authored by bartek). · Explain WhyMay 22 2024, 3:24 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMcdb9ee89587b: [protos][identity] Add username to AuthResponse.

Revision Contents
Changeset List

Path

Size

native/

native_rust_library/

src/

1 line

services/

identity/

src/

client_service.rs

18 lines

9 lines

shared/

protos/

identity_unauth.proto

2 lines

web/

protobufs/

identity-unauth-structs.cjs

identity-unauth-structs.cjs.flow

4 lines

Diff 40415

native/native_rust_library/src/identity.rs

Loading...

services/identity/src/client_service.rs

Loading...

services/identity/src/ddb_utils.rs

Loading...

shared/protos/identity_unauth.proto

Loading...

web/protobufs/identity-unauth-structs.cjs

Loading...

web/protobufs/identity-unauth-structs.cjs.flow

Loading...