Paths

Table of Contentst

Differential D12179

[rust] Fix Clippy warnings
ClosedPublic
Actions

Authored by bartek on May 22 2024, 5:58 AM.

Details

Reviewers

varun

Commits

rCOMMd6d4e0d7379b: [rust] Fix Clippy warnings

Summary

Fixed all remaining Clippy warnings for the workspace

Depends on D12178

Test Plan

No more Clippy warnings when running cargo check or cargo clippy

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.May 22 2024, 5:58 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 22 2024, 5:58 AM

Harbormaster failed remote builds in B29165: Diff 40536!May 22 2024, 6:01 AM

Rebase

bartek published this revision for review.May 22 2024, 7:45 AM

Harbormaster completed remote builds in B29174: Diff 40545.May 22 2024, 7:46 AM

varun accepted this revision.May 22 2024, 7:47 AM

This revision is now accepted and ready to land.May 22 2024, 7:47 AM

Rebase before landing

Harbormaster completed remote builds in B29270: Diff 40717.Tue, May 28, 8:07 AM

Closed by commit rCOMMd6d4e0d7379b: [rust] Fix Clippy warnings (authored by bartek). · Explain WhyTue, May 28, 8:12 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMd6d4e0d7379b: [rust] Fix Clippy warnings.

Revision Contents
Changeset List

Path

Size

keyserver/

addons/

rust-node-addon/

src/

identity_client/

1 line

mod.rs

1 line

register_user.rs

1 line

native/

native_rust_library/

src/

backup.rs

4 lines

identity/

1 line

registration.rs

1 line

x3dh.rs

1 line

lib.rs

1 line

services/

blob/

src/

service.rs

2 lines

commtest/

src/

identity/

mod.rs

2 lines

tests/

identity_access_tokens_tests.rs

2 lines

identity_one_time_key_tests.rs

4 lines

identity/

src/

database.rs

1 line

grpc_services/

shared.rs

4 lines

regex.rs

4 lines

siwe.rs

1 line

shared/

comm-lib/

src/

lib.rs

3 lines

Diff 40545

View Options

keyserver/addons/rust-node-addon/src/identity_client/login.rs

View Options

keyserver/addons/rust-node-addon/src/identity_client/mod.rs

View Options

keyserver/addons/rust-node-addon/src/identity_client/register_user.rs

View Options

native/native_rust_library/src/backup.rs

View Options

native/native_rust_library/src/identity/login.rs

View Options

native/native_rust_library/src/identity/registration.rs

View Options

native/native_rust_library/src/identity/x3dh.rs

View Options

native/native_rust_library/src/lib.rs

View Options

services/blob/src/service.rs

View Options

services/commtest/src/identity/mod.rs

View Options

services/commtest/tests/identity_access_tokens_tests.rs

View Options

services/commtest/tests/identity_one_time_key_tests.rs

View Options

services/identity/src/database.rs

View Options

services/identity/src/grpc_services/shared.rs

View Options

services/identity/src/regex.rs

View Options

services/identity/src/siwe.rs

View Options

shared/comm-lib/src/lib.rs

[rust] Fix Clippy warningsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 40545

keyserver/addons/rust-node-addon/src/identity_client/login.rs

keyserver/addons/rust-node-addon/src/identity_client/mod.rs

keyserver/addons/rust-node-addon/src/identity_client/register_user.rs

native/native_rust_library/src/backup.rs

native/native_rust_library/src/identity/login.rs

native/native_rust_library/src/identity/registration.rs

native/native_rust_library/src/identity/x3dh.rs

native/native_rust_library/src/lib.rs

services/blob/src/service.rs

services/commtest/src/identity/mod.rs

services/commtest/tests/identity_access_tokens_tests.rs

services/commtest/tests/identity_one_time_key_tests.rs

services/identity/src/database.rs

services/identity/src/grpc_services/shared.rs

services/identity/src/regex.rs

services/identity/src/siwe.rs

shared/comm-lib/src/lib.rs

[rust] Fix Clippy warnings
ClosedPublic
Actions

Revision Contents
Changeset List