Page MenuHomePhabricator

[native] Inline siweButton in LoggedOutModal
ClosedPublic

Authored by ashoat on May 22 2024, 7:44 AM.
Tags
None
Referenced Files
F4098588: D12193.diff
Mon, Feb 17, 1:46 AM
Unknown Object (File)
Wed, Feb 12, 7:40 AM
Unknown Object (File)
Fri, Jan 31, 7:46 PM
Unknown Object (File)
Mon, Jan 20, 12:06 AM
Unknown Object (File)
Mon, Jan 20, 12:06 AM
Unknown Object (File)
Mon, Jan 20, 12:05 AM
Unknown Object (File)
Mon, Jan 20, 12:04 AM
Unknown Object (File)
Sun, Jan 19, 6:00 AM
Subscribers

Details

Summary

As a first step towards replacing the Reanimated 1 syntax in LoggedOutModal with Reanimated 2 syntax (ENG-8146), I'm converting the class component to a function component.

Not clear why this was defined separately. Maybe it was used in multiple places previously?

Doing this as a separate diff because it's a simple move, to make later diffs easier to review.

Depends on D12192

Test Plan

I tested this diff stack by playing around with LoggedOutModal on my iOS simulator in my local environment:

  1. I navigated to LogInPanel and back
  2. I navigated to LegacyRegisterPanel and back
  3. I navigated to FullscreenSIWEPanel and back
  4. I navigated to QRCodeSignInNavigator and back
  5. I navigated to Registration and back

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage