Page MenuHomePhabricator

[native] Inline siweButton in LoggedOutModal
ClosedPublic

Authored by ashoat on May 22 2024, 7:44 AM.
Tags
None
Referenced Files
F2836004: D12193.id40563.diff
Sat, Sep 28, 3:15 PM
Unknown Object (File)
Thu, Sep 26, 1:17 AM
Unknown Object (File)
Thu, Sep 26, 1:17 AM
Unknown Object (File)
Thu, Sep 26, 1:16 AM
Unknown Object (File)
Thu, Sep 26, 1:14 AM
Unknown Object (File)
Tue, Sep 24, 1:21 PM
Unknown Object (File)
Sun, Sep 15, 10:37 PM
Unknown Object (File)
Sun, Sep 15, 11:46 AM
Subscribers

Details

Summary

As a first step towards replacing the Reanimated 1 syntax in LoggedOutModal with Reanimated 2 syntax (ENG-8146), I'm converting the class component to a function component.

Not clear why this was defined separately. Maybe it was used in multiple places previously?

Doing this as a separate diff because it's a simple move, to make later diffs easier to review.

Depends on D12192

Test Plan

I tested this diff stack by playing around with LoggedOutModal on my iOS simulator in my local environment:

  1. I navigated to LogInPanel and back
  2. I navigated to LegacyRegisterPanel and back
  3. I navigated to FullscreenSIWEPanel and back
  4. I navigated to QRCodeSignInNavigator and back
  5. I navigated to Registration and back

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage