Details
Details
In combination with later diffs, I tested as follows:
- I created a socket crash loop on a physical iOS device using @inka's create-many-threads-to-trigger-crash-loop.js script (see ENG-8090
- I confirmed that the socket was unable to connect prior to my diff stack
- I confirmed that after applying my diff stack, the SUCCESS action was dispatched, and the socket was able to connect afterwards
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/socket/socket.react.js | ||
|---|---|---|
| 700–708 ↗ | (On Diff #41149) | Thinking about this more, I wonder if we should just get rid of this older mechanism. It has the potential of logging the user out if recovery is not possible (web, or ETH user on native). Removing it would also let us deprecate showSocketCrashLoopAlert, which only exists to warn the user about the potential logout. I think the new mechanism should allow us to heal from any socket crash loop, including one that is the result of a policy acknowledgment after login. cc @kamil |
| lib/socket/socket.react.js | ||
|---|---|---|
| 714 ↗ | (On Diff #41149) | Should we somehow remember that this operation is in progress? I worry that it might be possible to start this action multiple times. |
| lib/socket/socket.react.js | ||
|---|---|---|
| 700–708 ↗ | (On Diff #41149) | Agree with that - I think we can remove it |