Page MenuHomePhabricator

[reports] Require auth for viewing reports
ClosedPublic

Authored by bartek on Jun 13 2024, 1:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 1:38 PM
Unknown Object (File)
Sun, Oct 13, 5:50 AM
Unknown Object (File)
Sun, Oct 13, 5:50 AM
Unknown Object (File)
Sun, Oct 13, 5:50 AM
Unknown Object (File)
Sun, Oct 13, 5:50 AM
Unknown Object (File)
Sun, Oct 13, 5:50 AM
Unknown Object (File)
Sep 28 2024, 12:32 AM
Unknown Object (File)
Sep 28 2024, 12:27 AM
Subscribers

Details

Summary

Wrapped viewing reports endpoints with auth middleware.
The POST /reports still works without auth - it is optional there and used only for retrieving user_id.

Depends on D12415

Test Plan
  • Repeated test plan from D12414 for /reports endpoints.
  • Verified that sending reports still works without auth.
  • Verified that user_id is present when sending reports with valid credentials.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Jun 13 2024, 2:12 AM

Heads-up, there are no reviewers specified here

This revision is now accepted and ready to land.Jun 17 2024, 9:01 PM
This revision was automatically updated to reflect the committed changes.