Page MenuHomePhabricator
Differential D12304

[identity] Add /inbound_keys HTTP handler
ClosedPublic
Actions

Authored by bartek on Jun 4 2024, 12:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 5, 5:42 PM
Unknown Object (File)
Fri, Nov 1, 5:29 PM
Unknown Object (File)
Oct 13 2024, 5:05 AM
Unknown Object (File)
Oct 13 2024, 5:05 AM
Unknown Object (File)
Oct 13 2024, 5:05 AM
Unknown Object (File)
Oct 13 2024, 5:05 AM
Unknown Object (File)
Oct 13 2024, 5:05 AM
Unknown Object (File)
Oct 13 2024, 5:05 AM
View All 57 Files
Subscribers
ashoat
tomek

Details

Reviewers
marcin
varun
will
Commits
rCOMMbe362d661778: [identity] Add /inbound_keys HTTP handler
Summary

Added HTTP endpoint for inbound keys. Request and response format described in ENG-8290.

Added some utility traits to leave handler with only business logic.

Depends on D12300, D12303

Test Plan

Registered a user with a few devices.

  • Called GetInboundKeysForUser RPC
  • Called /inbound_keys HTTP endpoint

Compared results.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Jun 4 2024, 12:59 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 4 2024, 12:59 AM
bartek added a child revision: D12305: [identity][terraform] Add error type for HTTP logs.Jun 4 2024, 1:01 AM
Harbormaster completed remote builds in B29414: Diff 40915.Jun 4 2024, 1:16 AM
bartek published this revision for review.Jun 4 2024, 8:14 AM
varun accepted this revision.Jun 6 2024, 3:31 AM
bartek planned changes to this revision.Jun 6 2024, 10:04 AM

I'll update this endpoint to return only single device

bartek updated this revision to Diff 41096.Jun 7 2024, 3:57 AM
bartek mentioned this in D12349: [identity] Add function to query device by ID.

Update handler to the new format

bartek added a parent revision: D12349: [identity] Add function to query device by ID.Jun 7 2024, 4:01 AM
bartek added inline comments.
services/identity/src/http/mod.rs
25 ↗(On Diff #41096)

I'm considering naming this /device_inbound_keys to indicate it's a single-device endpoint

Harbormaster failed remote builds in B29523: Diff 41096!Jun 7 2024, 4:02 AM
marcin accepted this revision.Jun 7 2024, 10:09 AM
This revision is now accepted and ready to land.Jun 7 2024, 10:09 AM
Harbormaster completed remote builds in B29523: Diff 41096.Jun 10 2024, 12:08 AM
bartek updated this revision to Diff 41365.Jun 17 2024, 2:24 AM

Name endpoint /device_inbound_keys to indicate it's single-device. Rebase before landing.

Harbormaster completed remote builds in B29705: Diff 41365.Jun 17 2024, 2:41 AM
Closed by commit rCOMMbe362d661778: [identity] Add /inbound_keys HTTP handler (authored by bartek). · Explain WhyJun 17 2024, 2:54 AM
This revision was automatically updated to reflect the committed changes.
bartek mentioned this in rCOMMe70a7793d320: [identity] Add function to query device by ID.
bartek added a commit: rCOMMbe362d661778: [identity] Add /inbound_keys HTTP handler.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
http/
27 lines
14 lines
64 lines

Diff 41365

View Options

services/identity/src/http/handlers.rs

Loading...
View Options

services/identity/src/http/mod.rs

Loading...
View Options

services/identity/src/http/utils.rs

Loading...