Page MenuHomePhabricator
Differential D12515

[identity] fix wallet account deletion bug
ClosedPublic
Actions

Authored by varun on Jun 20 2024, 11:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 3, 4:56 AM
Unknown Object (File)
Fri, Oct 25, 1:15 PM
Unknown Object (File)
Oct 12 2024, 3:10 PM
Unknown Object (File)
Oct 12 2024, 3:10 PM
Unknown Object (File)
Oct 12 2024, 3:10 PM
Unknown Object (File)
Oct 12 2024, 3:10 PM
Unknown Object (File)
Aug 29 2024, 6:28 PM
Unknown Object (File)
Aug 20 2024, 5:30 AM
View All 41 Files
Subscribers
ashoat
tomek

Details

Reviewers
will
bartek
Commits
rCOMM30437f95dcbf: [identity] fix wallet account deletion bug
Summary

in D12335 i missed that get_username_and_password_file returns an error if the username attribute is missing, causing the whole RPC to fail. rather than modify that db method, i've decided to introduce a new one that just checks for the existence of OPAQUE registration data in a user item. the method returns an error if the lookup fails or if the user doesn't exist.

Resolves https://linear.app/comm/issue/ENG-8474/wallet-account-deletion-not-working

Test Plan

tested on staging -- confirmed that wallet account deletion now works

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Jun 20 2024, 11:13 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 20 2024, 11:13 AM
varun published this revision for review.Jun 20 2024, 11:13 AM
Harbormaster completed remote builds in B29837: Diff 41572.Jun 20 2024, 11:30 AM
varun added a reviewer: bartek.Jun 20 2024, 1:11 PM
will accepted this revision.Jun 20 2024, 1:18 PM
varun added inline comments.Jun 20 2024, 9:08 PM
services/identity/src/database.rs
742

i'll remove the extra backtick

varun added a child revision: D12544: [identity] fix reserved username workflow for wallet users.Jun 21 2024, 4:36 PM
bartek accepted this revision.Jun 21 2024, 10:41 PM
bartek added inline comments.
services/identity/src/database.rs
749–751

any log what failed?

752–755

Nit. No even need to mutate

This revision is now accepted and ready to land.Jun 21 2024, 10:41 PM
Closed by commit rCOMM30437f95dcbf: [identity] fix wallet account deletion bug (authored by varun). · Explain WhyJun 24 2024, 10:29 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM30437f95dcbf: [identity] fix wallet account deletion bug.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
16 lines
grpc_services/
6 lines

Diff 41572

View Options

services/identity/src/database.rs

Loading...
View Options

services/identity/src/grpc_services/authenticated.rs

Loading...