Page MenuHomePhabricator

[web] inform password users that they need to log in from native to claim username
ClosedPublic

Authored by varun on Jun 21 2024, 4:46 PM.
Tags
None
Referenced Files
F3277343: D12546.id41628.diff
Sat, Nov 16, 7:49 AM
F3271587: D12546.diff
Sat, Nov 16, 5:12 AM
Unknown Object (File)
Fri, Nov 15, 10:00 AM
Unknown Object (File)
Sat, Nov 9, 6:48 AM
Unknown Object (File)
Sun, Oct 27, 1:20 AM
Unknown Object (File)
Oct 12 2024, 3:11 PM
Unknown Object (File)
Oct 12 2024, 3:11 PM
Unknown Object (File)
Oct 12 2024, 3:10 PM
Subscribers

Details

Summary

Depends on D12545

this is similar to the previous diff but for password users

Test Plan

tried logging in from web with a reserved username and got the expected error message

Screenshot 2024-06-21 at 5.17.30 PM.png (1×1 px, 114 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun requested review of this revision.Jun 21 2024, 5:02 PM

i'll try to shorten the message so it fits on one line. looks a little janky rn

Why would a user be claiming a username from login screen? Isn't claiming username registration?

In D12546#355463, @inka wrote:

Why would a user be claiming a username from login screen? Isn't claiming username registration?

User A registers directly with Ashoat’s keyserver. Then we flip the usingCSAT switch. The next time A tries to log in from native, we register them with identity transparently

Looks good, but is there a follow up task/diff to address the janky ui?

This revision is now accepted and ready to land.Jun 24 2024, 10:16 AM

Looks good, but is there a follow up task/diff to address the janky ui?

I'm just going to shorten the message before landing to 'please log in from a mobile device then retry' so that it fits on one line