Paths

Table of Contentst

Differential D12589

[identity] Make apply_devicelist_update more generic
ClosedPublic
Actions

Authored by bartek on Thu, Jun 27, 7:32 AM.

Tags

None

Referenced Files

	F2184288: D12589.id41751.diff
	Wed, Jul 3, 8:46 PM

	F2184101: D12589.id41757.diff
	Wed, Jul 3, 8:41 PM

	F2181176: D12589.id41758.diff
	Wed, Jul 3, 5:11 PM

	F2178617: D12589.id41752.diff
	Wed, Jul 3, 11:10 AM

	F2175699: D12589.id41757.diff
	Wed, Jul 3, 3:10 AM

	Unknown Object (File)
	Tue, Jul 2, 4:34 AM

	Unknown Object (File)
	Tue, Jul 2, 4:15 AM

	Unknown Object (File)
	Mon, Jul 1, 8:00 PM

View All 15 Files

Subscribers

Details

Reviewers

kamil
varun
will

Commits

rCOMMfdd22dcce572: [identity] Make apply_devicelist_update more generic

Summary

Currently, apply_devicelist_update requires a device list validator, and also has side effects (removes device data when it's removed from the list).
Usually we want this, but there are usecases when either of them is not needed - when these actions are performed externally.

Depends on D12588

Test Plan

Commtest. Confirmed that UpdateDeviceList RPC still works as expected - validates the device list and removes device data.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Thu, Jun 27, 7:32 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Jun 27, 7:32 AM

bartek added a child revision: D12590: [identity] Implement LogOutPrimaryDevice RPC.Thu, Jun 27, 7:38 AM

Rebase

Harbormaster failed remote builds in B29954: Diff 41751!Thu, Jun 27, 8:10 AM

Harbormaster completed remote builds in B29960: Diff 41757.Thu, Jun 27, 8:39 AM

bartek published this revision for review.Fri, Jun 28, 1:05 AM

kamil accepted this revision.Mon, Jul 1, 3:08 AM

This revision is now accepted and ready to land.Mon, Jul 1, 3:08 AM

Closed by commit rCOMMfdd22dcce572: [identity] Make apply_devicelist_update more generic (authored by bartek). · Explain WhyWed, Jul 3, 3:08 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMfdd22dcce572: [identity] Make apply_devicelist_update more generic.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

database/

28 lines

grpc_services/

authenticated.rs

8 lines

Diff 41751

services/identity/src/database/device_list.rs

Loading...

services/identity/src/grpc_services/authenticated.rs

Loading...