Page MenuHomePhabricator
Differential D12589

[identity] Make apply_devicelist_update more generic
ClosedPublic
Actions

Authored by bartek on Jun 27 2024, 7:32 AM.
Tags
None
Referenced Files
F3775524: D12589.id41936.diff
Mon, Jan 13, 1:11 AM
Unknown Object (File)
Sat, Jan 11, 10:33 AM
Unknown Object (File)
Sun, Jan 5, 4:52 PM
Unknown Object (File)
Mon, Dec 23, 3:28 PM
Unknown Object (File)
Mon, Dec 23, 3:28 PM
Unknown Object (File)
Mon, Dec 23, 3:28 PM
Unknown Object (File)
Mon, Dec 23, 3:27 PM
Unknown Object (File)
Mon, Dec 23, 3:27 PM
View All 73 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
varun
will
Commits
rCOMMfdd22dcce572: [identity] Make apply_devicelist_update more generic
Summary

Currently, apply_devicelist_update requires a device list validator, and also has side effects (removes device data when it's removed from the list).
Usually we want this, but there are usecases when either of them is not needed - when these actions are performed externally.

Depends on D12588

Test Plan

Commtest. Confirmed that UpdateDeviceList RPC still works as expected - validates the device list and removes device data.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
services/
identity/
src/
database/
28 lines
grpc_services/
8 lines

Diff 41757

View Options

services/identity/src/database/device_list.rs

Loading...
View Options

services/identity/src/grpc_services/authenticated.rs

Loading...