Page MenuHomePhabricator
Differential D12523

[Tunnelbroker] handle `SetDeviceToken` message
ClosedPublic
Actions

Authored by kamil on Thu, Jun 20, 2:54 PM.
Tags
None
Referenced Files
F2145666: D12523.id41582.diff
Sat, Jun 29, 10:32 PM
Unknown Object (File)
Thu, Jun 27, 7:49 PM
Unknown Object (File)
Thu, Jun 27, 2:19 PM
Unknown Object (File)
Thu, Jun 27, 1:42 PM
Unknown Object (File)
Wed, Jun 26, 10:48 PM
Unknown Object (File)
Wed, Jun 26, 11:03 AM
Unknown Object (File)
Tue, Jun 25, 10:44 AM
Unknown Object (File)
Mon, Jun 24, 11:53 AM
View All 12 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
marcin
Commits
rCOMM36a8f028c429: [Tunnelbroker] handle `SetDeviceToken` message
Summary

ENG-8347

Code to handle message from the client.

Depends on D12520, D12522

Test Plan

Tested in next diff

Diff Detail

Repository
rCOMM Comm
Branch
landing-token
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Thu, Jun 20, 2:54 PM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Jun 20, 2:54 PM
kamil added a child revision: D12524: [lib] implement sending message to Tunnelbroker.Thu, Jun 20, 2:55 PM
Harbormaster failed remote builds in B29845: Diff 41580!Thu, Jun 20, 3:00 PM
kamil published this revision for review.Thu, Jun 20, 4:12 PM
Harbormaster completed remote builds in B29845: Diff 41580.Thu, Jun 20, 4:28 PM
bartek accepted this revision.Fri, Jun 21, 11:11 PM
bartek added inline comments.
services/tunnelbroker/src/websockets/session.rs
327–329 ↗(On Diff #41580)

I guess the type can be inferred from handle_message_to_tunnelbroker() call below

338–341 ↗(On Diff #41580)

Wondering why we're using Option::from() everywhere. Simple Some() would work too

This revision is now accepted and ready to land.Fri, Jun 21, 11:11 PM
kamil updated this revision to Diff 41801.Fri, Jun 28, 6:17 AM

address nits

Harbormaster completed remote builds in B29997: Diff 41801.Fri, Jun 28, 6:34 AM
Closed by commit rCOMM36a8f028c429: [Tunnelbroker] handle `SetDeviceToken` message (authored by kamil). · Explain WhyFri, Jun 28, 6:48 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM36a8f028c429: [Tunnelbroker] handle `SetDeviceToken` message.

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
websockets/
55 lines

Diff 41801

View Options

services/tunnelbroker/src/websockets/session.rs

Loading...