Paths

Table of Contentst

Differential D12523

[Tunnelbroker] handle `SetDeviceToken` message
ClosedPublic
Actions

Authored by kamil on Jun 20 2024, 9:54 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

bartek
marcin

Commits

rCOMM36a8f028c429: [Tunnelbroker] handle `SetDeviceToken` message

Summary

Code to handle message from the client.

Depends on D12520, D12522

Test Plan

Tested in next diff

Diff Detail

Repository

Branch

landing-token

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jun 20 2024, 9:54 PM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 20 2024, 9:54 PM

kamil added a child revision: D12524: [lib] implement sending message to Tunnelbroker.Jun 20 2024, 9:55 PM

Harbormaster failed remote builds in B29845: Diff 41580!Jun 20 2024, 10:00 PM

kamil published this revision for review.Jun 20 2024, 11:12 PM

Harbormaster completed remote builds in B29845: Diff 41580.Jun 20 2024, 11:28 PM

bartek accepted this revision.Jun 22 2024, 6:11 AM

bartek added inline comments.

services/tunnelbroker/src/websockets/session.rs
327–329 ↗	(On Diff #41580)	I guess the type can be inferred from `handle_message_to_tunnelbroker()` call below
338–341 ↗	(On Diff #41580)	Wondering why we're using `Option::from()` everywhere. Simple `Some()` would work too

This revision is now accepted and ready to land.Jun 22 2024, 6:11 AM

address nits

Harbormaster completed remote builds in B29997: Diff 41801.Jun 28 2024, 1:34 PM

Closed by commit rCOMM36a8f028c429: [Tunnelbroker] handle `SetDeviceToken` message. · Explain WhyJun 28 2024, 1:48 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM36a8f028c429: [Tunnelbroker] handle `SetDeviceToken` message.

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

websockets/

55 lines

Diff 41801

services/tunnelbroker/src/websockets/session.rs

Loading...