[Tunnelbroker][lib] add APNs notif message type
ClosedPublic
Actions

Authored by kamil on Jun 28 2024, 5:41 AM.

Details

Reviewers

bartek
marcin

Commits

rCOMM7c0f632a8b8b: [Tunnelbroker][lib] add APNs notif message type

Summary

Message send from client to send notif using APNs.

As a response to that message using MessageToDeviceRequestStatus which is exactly what we need - follow-up task to rename this to something more generic (ENG-8609).

Depends on D12614

Test Plan

Tested in D12617.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jun 28 2024, 5:41 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 28 2024, 5:41 AM

kamil added a child revision: D12616: [Tunnelbroker] implement sending APNs notifs by client.Jun 28 2024, 5:46 AM

kamil edited the test plan for this revision. (Show Details)Jun 28 2024, 5:52 AM

Harbormaster completed remote builds in B29994: Diff 41793.Jun 28 2024, 5:57 AM

kamil published this revision for review.Jun 28 2024, 6:33 AM

kamil edited the summary of this revision. (Show Details)

Are any validator changes necessary here?

marcin accepted this revision.Jul 2 2024, 2:10 AM

This revision is now accepted and ready to land.Jul 2 2024, 2:10 AM

In D12615#357420, @ashoat wrote:

Are any validator changes necessary here?

No, this is a message from the device to Tunnelbroker only so validation is handled on the Rust side by serde. This could be confusing, some additional context in point 5 in ENG-8621.

Closed by commit rCOMM7c0f632a8b8b: [Tunnelbroker][lib] add APNs notif message type (authored by kamil). · Explain WhyJul 2 2024, 8:35 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM7c0f632a8b8b: [Tunnelbroker][lib] add APNs notif message type.